Merge lp:~gary/launchpad/fix-578-patch into lp:launchpad

Proposed by Gary Poster
Status: Merged
Merged at revision: 12338
Proposed branch: lp:~gary/launchpad/fix-578-patch
Merge into: lp:launchpad
Diff against target: 12 lines (+8/-0)
1 file modified
database/schema/patch-2208-38-1.sql (+8/-0)
To merge this branch: bzr merge lp:~gary/launchpad/fix-578-patch
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Gary Poster (community) db Approve
Ian Booth (community) release-critical Approve
Robert Collins db Pending
Stuart Bishop db Pending
Review via email: mp+48786@code.launchpad.net

Commit message

[release-critical=wallyworld][r=bac,gary][no-qa] adds a missing SQL insert statement

Description of the change

This branch adds a missing SQL insert statement. It takes about 2 minutes to run on staging, according to stub. It was supposed to be a part of https://code.launchpad.net/~gary/launchpad/bug548-db-2/+merge/48318 but we missed it.

Without it, the branch to be deployed gives https://pastebin.canonical.com/42925/ as the output. With it, as verified by stub applying on staging, we get emails properly again.

To post a comment you must log in.
Revision history for this message
Ian Booth (wallyworld) :
review: Approve (release-critical)
Revision history for this message
Gary Poster (gary) wrote :

stub gave me an rs on IRC earlier, so I'll make the call here:

gary: ok, I'll point them to this conversation then. Are you going to be around long enough for me to make 38-1 and get your blessing then, stub, or should I break protocol?
stub: rs=stub.
gary: got it
gary: thanks
stub: i might be here but its not rocketscience this one

review: Approve (db)
Revision history for this message
Brad Crittenden (bac) wrote :

The patch looks good to me. (I think an additional set of eyes is good but I don't think a code review is necessary here.)

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'database/schema/patch-2208-38-1.sql'
2--- database/schema/patch-2208-38-1.sql 1970-01-01 00:00:00 +0000
3+++ database/schema/patch-2208-38-1.sql 2011-02-07 15:12:19 +0000
4@@ -0,0 +1,8 @@
5+SET client_min_messages=ERROR;
6+
7+INSERT INTO PersonSettings (person)
8+ SELECT id FROM Person WHERE teamowner IS NULL;
9+
10+INSERT INTO LaunchpadDatabaseRevision VALUES (2208, 38, 1);
11+
12+