Merge lp:~gary/launchpad/bug548-db-2 into lp:launchpad/db-devel

[Gary Poster]

[r=allenap,stub][ui=none][bug=548] Add "selfgenerated_bugnotifications" as a global option for people so that we can work on bug 548. Only in the DB at this time, since the actual implementation is not yet done.

I made https://code.launchpad.net/~gary/launchpad/bug548-db/+merge/48263 in order to try and add a column to person named "selfgenerated_bugnotifications" so that we can work on bug 548 on devel after the upcoming rollout. The intended use is as described in https://dev.launchpad.net/yellow/Subscriptions#Turning%20off%20emails%20about%20your%20own%20actions .

Beyond some relatively superficial problems, Stuart and Robert expressed fundamental concern about adding more columns to the Person table. Stuart suggested an alternate approach, and implemented the SQL for me. Thank you!

His SQL had two aspects I had to remove. The first, which I did with his blessing, is that I switched from using a trigger to create PersonSettings to using __init__. This fixed some access problems I found in tests, in which a newly-created Person object would not yet have a PersonSettings object around.

The other aspect is that he had moved verbose_bugnotifications to the personsettings table. He wants personsettings to only hold information pertinent to people, rather than teams. It turns out that verbose_bugnotifications is an attribute used by teams, and tested as such. Therefore, I did not have to change the Person table at all, which made this branch a lot smaller than it was initially.

On the downside, in his original change, the Person table actually shrank a very small bit, while in the current version, it merely stays as it was. Making another table for shared Person-Team settings is unnecessary and out of scope for this branch.

I threw in a quick test to show that the new attribute was available. I was reading doctests to figure out what was going on and found them helpful, so I just threw the smoketest in there for now. When we actually have this feature implemented, I will advocate maintaining the doctests for new readers like me, while moving exceptional cases to unit tests.

Gary

[Stuart Bishop (stub)]

Fine.

I suspect PersonSettings will end up with team settings too, but for now this is fine.

review: Approve (db)

[Gavin Panella (allenap)]

I really like the:

+ @cachedproperty
+ def _person_settings(self):
...
+ delegates(IPersonSettings, context='_person_settings')

pattern. Neat.

review: Approve

[Gary Poster (gary)]

Thank you!

=== modified file 'database/sampledata/current-dev.sql'
--- database/sampledata/current-dev.sql	2011-01-28 12:44:50 +0000
+++ database/sampledata/current-dev.sql	2011-02-02 18:09:33 +0000
@@ -6306,6 +6306,112 @@
 ALTER TABLE personnotification ENABLE TRIGGER ALL;
 
 
+ALTER TABLE personsettings DISABLE TRIGGER ALL;
+
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (1, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (2, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (3, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (4, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (5, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (6, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (7, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (8, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (9, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (10, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (11, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (12, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (13, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (14, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (16, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (17, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (18, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (19, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (20, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (21, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (22, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (23, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (24, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (25, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (26, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (27, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (28, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (29, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (30, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (31, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (32, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (33, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (34, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (35, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (36, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (37, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (38, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (39, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (40, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (41, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (42, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (43, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (44, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (45, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (46, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (47, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (48, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (49, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (50, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (51, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (52, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (53, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (55, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (56, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (57, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (58, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (59, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (60, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (61, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (62, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (63, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (64, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (65, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (66, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (67, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (68, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (69, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (70, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243601, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243602, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243603, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243604, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243606, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243607, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243608, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243609, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243610, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243611, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243612, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243613, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243614, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243615, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243616, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243617, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243618, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243620, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243621, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243622, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243623, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243624, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243625, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243626, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243627, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243628, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243629, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243630, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243631, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243632, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243651, true);
+
+
+ALTER TABLE personsettings ENABLE TRIGGER ALL;
+
+
 ALTER TABLE persontransferjob DISABLE TRIGGER ALL;
 
 

=== modified file 'database/sampledata/current.sql'
--- database/sampledata/current.sql	2011-01-28 12:44:50 +0000
+++ database/sampledata/current.sql	2011-02-02 18:09:33 +0000
@@ -6311,6 +6311,112 @@
 ALTER TABLE personnotification ENABLE TRIGGER ALL;
 
 
+ALTER TABLE personsettings DISABLE TRIGGER ALL;
+
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (1, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (2, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (3, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (4, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (5, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (6, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (7, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (8, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (9, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (10, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (11, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (12, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (13, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (14, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (16, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (17, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (18, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (19, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (20, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (21, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (22, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (23, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (24, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (25, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (26, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (27, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (28, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (29, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (30, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (31, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (32, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (33, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (34, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (35, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (36, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (37, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (38, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (39, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (40, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (41, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (42, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (43, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (44, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (45, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (46, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (47, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (48, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (49, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (50, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (51, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (52, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (53, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (55, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (56, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (57, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (58, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (59, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (60, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (61, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (62, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (63, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (64, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (65, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (66, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (67, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (68, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (69, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (70, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243601, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243602, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243603, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243604, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243606, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243607, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243608, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243609, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243610, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243611, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243612, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243613, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243614, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243615, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243616, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243617, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243618, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243620, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243621, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243622, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243623, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243624, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243625, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243626, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243627, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243628, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243629, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243630, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243631, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243632, true);
+INSERT INTO personsettings (person, selfgenerated_bugnotifications) VALUES (243651, true);
+
+
+ALTER TABLE personsettings ENABLE TRIGGER ALL;
+
+
 ALTER TABLE persontransferjob DISABLE TRIGGER ALL;
 
 

=== modified file 'database/schema/comments.sql'
--- database/schema/comments.sql	2011-01-28 12:44:50 +0000
+++ database/schema/comments.sql	2011-02-02 18:09:33 +0000
@@ -1267,6 +1267,9 @@
 COMMENT ON COLUMN Person.visibility IS 'person.PersonVisibility enumeration which can be set to Public, Public with Private Membership, or Private.';
 COMMENT ON COLUMN Person.verbose_bugnotifications  IS 'If true, all bugnotifications sent to this Person will include the bug description.';
 
+COMMENT ON TABLE PersonSettings IS 'Flags and settings corresponding to a Person. These are in a separate table to remove infrequently used data from the Person table itself.';
+COMMENT ON COLUMN PersonSettings.selfgenerated_bugnotifications  IS 'If true, users receive bugnotifications for actions they personally triggered.';
+
 COMMENT ON VIEW ValidPersonCache IS 'A materialized view listing the Person.ids of all valid people (but not teams).';
 
 -- PersonLanguage

=== added file 'database/schema/patch-2208-38-0.sql'
--- database/schema/patch-2208-38-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2208-38-0.sql	2011-02-02 18:09:33 +0000
@@ -0,0 +1,7 @@
+SET client_min_messages=ERROR;
+
+CREATE TABLE PersonSettings (
+    person integer PRIMARY KEY REFERENCES Person ON DELETE CASCADE,
+    selfgenerated_bugnotifications boolean NOT NULL DEFAULT TRUE);
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2208, 38, 0);

=== modified file 'database/schema/security.cfg'
--- database/schema/security.cfg	2011-02-01 18:52:06 +0000
+++ database/schema/security.cfg	2011-02-02 18:09:33 +0000
@@ -220,6 +220,7 @@
 public.packaging                        = SELECT, INSERT, UPDATE, DELETE
 public.personlanguage                   = SELECT, INSERT, UPDATE, DELETE
 public.personlocation                   = SELECT, INSERT, UPDATE, DELETE
+public.personsettings                   = SELECT, INSERT, UPDATE
 public.persontransferjob                = SELECT, INSERT, UPDATE, DELETE
 public.personnotification               = SELECT, INSERT, UPDATE, DELETE
 public.pillarname                       = SELECT, INSERT, DELETE
@@ -1477,6 +1478,7 @@
 public.component                        = SELECT
 public.packagebugsupervisor             = SELECT
 public.person                           = SELECT
+public.personsettings                   = SELECT
 public.personlanguage                   = SELECT
 public.product                          = SELECT, UPDATE
 public.project                          = SELECT, UPDATE

=== modified file 'lib/lp/bugs/doc/bugnotification-sending.txt'
--- lib/lp/bugs/doc/bugnotification-sending.txt	2011-02-01 04:57:42 +0000
+++ lib/lp/bugs/doc/bugnotification-sending.txt	2011-02-02 18:09:33 +0000
@@ -1098,6 +1098,25 @@
      '  people very angry and has been widely regarded as a bad move',
      '']
 
+Self-Generated Bug Notifications
+--------------------------------
+
+People (not teams) will have the choice to receive notifications from actions
+they generated.  For now, everyone receives these notifications whether they
+want them or not.  However, we can show that the attribute exists for now.
+
+    >>> flush_notifications()
+    >>> switch_db_to_launchpad()
+    >>> verbose_person.selfgenerated_bugnotifications
+    True
+
+Teams do not implement this attribute.
+
+    >>> verbose_team.selfgenerated_bugnotifications
+    Traceback (most recent call last):
+    ...
+    NotImplementedError: Teams do not support this attribute.
+
 Notification Recipients
 -----------------------
 

=== modified file 'lib/lp/registry/interfaces/person.py'
--- lib/lp/registry/interfaces/person.py	2011-01-10 14:55:31 +0000
+++ lib/lp/registry/interfaces/person.py	2011-02-02 18:09:33 +0000
@@ -16,6 +16,7 @@
     'IPersonClaim',
     'IPersonPublic', # Required for a monkey patch in interfaces/archive.py
     'IPersonSet',
+    'IPersonSettings',
     'ISoftwareCenterAgentAPI',
     'ISoftwareCenterAgentApplication',
     'IPersonViewRestricted',
@@ -584,10 +585,30 @@
         description=_("The reason the person's standing is what it is."))
 
 
+class IPersonSettings(Interface):
+    """Settings for a person (not a team!) that are used relatively rarely.
+
+    We store these attributes on a separate object, PersonSettings, to which
+    the Person class delegates.  This makes it possible to shrink the size of
+    the person record.
+
+    In the future, perhaps we will adapt IPerson to IPersonSettings when
+    we want these attributes instead of delegating, so we can shrink the
+    class, too.
+
+    We also may want TeamSettings and PersonTeamSettings in the future.
+    """
+
+    selfgenerated_bugnotifications = Bool(
+        title=_("Send me bug notifications for changes I make."),
+        required=False, default=True)
+
+
 class IPersonPublic(IHasBranches, IHasSpecifications,
                     IHasMergeProposals, IHasLogo, IHasMugshot, IHasIcon,
                     IHasLocation, IHasRequestedReviews, IObjectWithLocation,
-                    IPrivacy, IHasBugs, IHasRecipes, IHasTranslationImports):
+                    IPrivacy, IHasBugs, IHasRecipes, IHasTranslationImports,
+                    IPersonSettings):
     """Public attributes for a Person."""
 
     id = Int(title=_('ID'), required=True, readonly=True)

=== modified file 'lib/lp/registry/model/person.py'
--- lib/lp/registry/model/person.py	2011-02-01 18:52:06 +0000
+++ lib/lp/registry/model/person.py	2011-02-02 18:09:33 +0000
@@ -36,6 +36,8 @@
 import subprocess
 import weakref
 
+from lazr.delegates import delegates
+from lazr.restful.fields import Reference
 import pytz
 from sqlobject import (
     BoolCol,
@@ -50,6 +52,7 @@
     OR,
     SQLConstant,
     )
+from storm.base import Storm
 from storm.expr import (
     Alias,
     And,
@@ -65,6 +68,10 @@
     Upper,
     )
 from storm.info import ClassAlias
+from storm.locals import (
+    Int,
+    Reference,
+    )
 from storm.store import (
     EmptyResultSet,
     Store,
@@ -216,6 +223,7 @@
     InvalidName,
     IPerson,
     IPersonSet,
+    IPersonSettings,
     ITeam,
     PersonalStanding,
     PersonCreationRationale,
@@ -351,6 +359,18 @@
     return "%s, %s" % (displayname.strip(), person.name)
 
 
+class PersonSettings(Storm):
+
+    implements(IPersonSettings)
+
+    __storm_table__ = 'PersonSettings'
+
+    personID = Int("person", default=None, primary=True)
+    person = Reference(personID, "Person.id")
+
+    selfgenerated_bugnotifications = BoolCol(notNull=True, default=True)
+
+
 class Person(
     SQLBase, HasBugsBase, HasSpecificationsMixin, HasTranslationImportsMixin,
     HasBranchesMixin, HasMergeProposalsMixin, HasRequestedReviewsMixin):
@@ -358,6 +378,33 @@
 
     implements(IPerson, IHasIcon, IHasLogo, IHasMugshot)
 
+    def __init__(self, *args, **kwargs):
+        super(Person, self).__init__(*args, **kwargs)
+        # Initialize our PersonSettings object/record.
+        if not self.is_team:
+            # This is a Person, not a team.  Teams may want a TeamSettings
+            # in the future.
+            settings = PersonSettings()
+            settings.person = self
+
+    @cachedproperty
+    def _person_settings(self):
+        if self.is_team:
+            # Hopefully no-one ever encounters this.  If someone does,
+            # that means that the code is trying to look at
+            # person-specific attributes on a team, and we should warn
+            # about that explicitly to give a hint about what is wrong
+            # (rather than merely returning None).
+            raise NotImplementedError(
+                'Teams do not support this attribute.')
+        else:
+            # This is a person.
+            return IStore(PersonSettings).find(
+                PersonSettings,
+                PersonSettings.person == self).one()
+
+    delegates(IPersonSettings, context='_person_settings')
+
     sortingColumns = SQLConstant(
         "person_sort_key(Person.displayname, Person.name)")
     # Redefine the default ordering into Storm syntax.
@@ -3815,6 +3862,7 @@
             ('teamparticipation', 'team'),
             ('personlanguage', 'person'),
             ('person', 'merged'),
+            ('personsettings', 'person'),
             ('emailaddress', 'person'),
             # Polls are not carried over when merging teams.
             ('poll', 'team'),