Code review comment for lp:~gary/launchpad/bug838878
Revision history for this message
| Gary Poster (gary) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
On Sep 1, 2011, at 3:45 PM, j.c.sackett wrote:
> Review: Approve
> Gary--
>
> This looks good. I see one possible problem in the updated profile template, pointed out below.
...
>
> I may be misunderstanding this, but shouldn't this be "separated with ambersands" as shown in the example?
Ah, yes, thanks, good catch!
...
> There's no problem in the above bit, just thought that was one hell of a generator expression. :-P
Yeah...not the prettiest thing in the world. Maybe I should have been more explicit/less concise...
Thanks again,
Gary