Code review comment for lp:~gary/launchpad/bug821531

Revision history for this message
Benji York (benji) wrote :

This looks good. Thanks for considering my input.

One thing I didn't notice the first time around (assuming I'm reading
the code correctly): starting on line 279 of the diff, if the user
provides just "log" they will get callgrind output, if they provide
"callgrind" and "pstats" they get both, but if they provide "log" and
"pstats" they will get just "pstats". Given the internal nature of the
code, this corner case is not pressing.

review: Approve (code)

« Back to merge proposal