Code review comment for lp:~gary/launchpad/bug821531

Revision history for this message
Gary Poster (gary) wrote :

I made all changes that you suggested/requested except the '-'.join(...) approach: I prefer the template approach for the filename.

I changed all test docstrings to comments: many of them were wrapping, and as you hinted, comments are reasonable and maybe even preferred for these descriptions anyway.

I'm asking you for a re-review given the size of the changes.

Lint is still as happy as it was ("happy except for being confused with the start of profile.pt"). Thanks!

« Back to merge proposal