Code review comment for lp:~gary/launchpad/bug741684

Revision history for this message
j.c.sackett (jcsackett) wrote :

Gary--

This is a clear improvement, thanks.

If we continue to see issues with scripts/bugnotification.py, I think there is still a chance that there's some churn in the for loop that repeatedly calls get_filter_descriptions (and through it, your improved getFiltersByRecipient), but you've done a lot to make that section cleaner.

review: Approve

« Back to merge proposal