Merge lp:~gary/launchpad/bug740631 into lp:launchpad/db-devel
Status: | Merged |
---|---|
Approved by: | Gary Poster |
Approved revision: | no longer in the source branch. |
Merged at revision: | 10639 |
Proposed branch: | lp:~gary/launchpad/bug740631 |
Merge into: | lp:launchpad/db-devel |
Diff against target: |
640 lines (+171/-108) 11 files modified
lib/canonical/launchpad/icing/sprite.css.in (+8/-0) lib/lp/bugs/browser/bug.py (+4/-4) lib/lp/bugs/browser/bugsubscription.py (+15/-9) lib/lp/bugs/browser/tests/test_bug_views.py (+10/-0) lib/lp/bugs/browser/tests/test_bugsubscription_views.py (+43/-8) lib/lp/bugs/javascript/bugtask_index_portlets.js (+56/-52) lib/lp/bugs/javascript/subscription.js (+9/-10) lib/lp/bugs/javascript/tests/test_subscription.js (+6/-9) lib/lp/bugs/templates/bug-portlet-subscription.pt (+3/-2) lib/lp/registry/javascript/structural-subscription.js (+6/-6) lib/lp/registry/javascript/tests/test_structural_subscription.js (+11/-8) |
To merge this branch: | bzr merge lp:~gary/launchpad/bug740631 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Данило Шеган (community) | Approve | ||
Review via email: mp+63251@code.launchpad.net |
Commit message
[r=danilo][bug=740631] Fix multiple problems with the mute functionality and interactions on the bug page, add separate mute/unmute icons, and fix other assorted problems along the way.
Description of the change
Despite the fact that the name of this branch is bug740631 (adding distinguishable icons for mute and unmute), the main point of it is to polish up the mute/unmute changes before they go live to everyone next week. We expected them to be addressed by our rework of these bits for bug 772754, but that's not quite ready yet. Therefore, this branch spends a bit of time polishing what we have.
This addresses the following issues identified by Danilo in his qa of the work for bug 772763:
> - "Unmute" links keeps pointing to "+subscribe" instead of "+mute" (+mute page was changed to
> support both muting/unmuting, and doesn't redirect to +subscribe when bug mail is muted anymore);
> this means that people will be sent to the wrong page if they have no JS
This was a simple change in lib/lp/
> - When there is a mute on a bug, but no subscription, clicking on "Subscribe" fails to pop-up the
> window; also, going to +subscribe page renders an empty form which doesn't work in that case (this
> two are likely related)
I addressed this by adding an option within lib/lp/
> - When one tries to "Subscribe" originally (or unmute when they have an old subscription, or
> unsubscribe yourself), subscription overlay pop-up stays loaded when you click on check-mark to
> apply the action even though the action succeeds; this is especially bad if there's an error since
> then the error pop-up is below the subscription overlay
I found this to be tricky to address with the existing JS, but the changes in lib/lp/
I also addressed the following problems.
- Anonymous users would get an OOPS when they visited a bug page if the feature flag was turned on for them.
- test_unmute_unmutes was getting a cached value for self.bug.
- In some cases, two instances of the user's name would be added to the "directly subscribed" display.
- In some cases, an instance of the user's name would turn permanently green after a success "flash".
- +subscriptions had not been modified to take advantage of the new mute functionality. I did so by changing options.
- The test for the ellipsis hack in lib/lp/
In addition to that, I added in the new mute/unmute icons Huw provided for bug 740631.
Thank you,
Gary
Other than the check Y.Lang. isValue( do_next) which you promised to make Y.Lang. isFunction( do_next) , everything looks great.