Launchpad itself

mute and umute bug subscription doesn't change icon

Bug #740631 reported by Diogo Matsubara
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Gary Poster

Bug Description

If you mute or unmute a bug report, the link changes the verb (mute/unmute) but it doesn't change the icon.
See Screenshot1 and Screenshot3.

I don't know what the icon should be, but it's a common pattern for the icon to change once you change something on LP (e.g. subscribe/edit subscription changes the icon from the green plus sign to the yellow edit pencil)

See original description

Related branches

lp:~gary/launchpad/bug740631
Данило Шеган (community): Approve
Diff: 640 lines (+171/-108)
11 files modified
lib/canonical/launchpad/icing/sprite.css.in (+8/-0)
lib/lp/bugs/browser/bug.py (+4/-4)
lib/lp/bugs/browser/bugsubscription.py (+15/-9)
lib/lp/bugs/browser/tests/test_bug_views.py (+10/-0)
lib/lp/bugs/browser/tests/test_bugsubscription_views.py (+43/-8)
lib/lp/bugs/javascript/bugtask_index_portlets.js (+56/-52)
lib/lp/bugs/javascript/subscription.js (+9/-10)
lib/lp/bugs/javascript/tests/test_subscription.js (+6/-9)
lib/lp/bugs/templates/bug-portlet-subscription.pt (+3/-2)
lib/lp/registry/javascript/structural-subscription.js (+6/-6)
lib/lp/registry/javascript/tests/test_structural_subscription.js (+11/-8)
Revision history for this message
Diogo Matsubara (matsubara) wrote :
Revision history for this message
Diogo Matsubara (matsubara) wrote :
description: updated
Revision history for this message
Robert Collins (lifeless) wrote :

Updated metadata per https://dev.launchpad.net/BugTriage#How to triage

Changed in launchpad:
importance: Undecided → High
Revision history for this message
Gary Poster (gary) wrote :

I contacted Huw about this bug, asking him for icons for mute and unmute.

Данило Шеган (danilo)
Changed in launchpad:
assignee: nobody → Данило Шеган (danilo)
Revision history for this message
Данило Шеган (danilo) wrote :

Not much to do until icons are available :)

Changed in launchpad:
assignee: Данило Шеган (danilo) → Launchpad Yellow Squad (yellow)
Revision history for this message
Jonathan Lange (jml) wrote :

Hi Huw,

Can you please get icons for the yellow squad on this?

cheers,
jml

Changed in launchpad:
assignee: Launchpad Yellow Squad (yellow) → Huw Wilkins (huwshimi)
Revision history for this message
Huw Wilkins (huwshimi) wrote :

Here are some icons. I'm not entirely sure they represent muting/unmuting that well and it's hard to represent very much inside the tiny circle. Any comments welcome.

Revision history for this message
Huw Wilkins (huwshimi) wrote :

That last image wasn't very helpful. Here's a mockup with the icons how they would appear with the links.

Revision history for this message
Huw Wilkins (huwshimi) wrote :

If these files are ok, I can provide the image files or push a branch.

Revision history for this message
Gary Poster (gary) wrote :

Hi Huw. I think these look good. Thank you.

Could you provide the files? I can slip this work in with the last feature bug I'm working on.

Revision history for this message
Huw Wilkins (huwshimi) wrote :

Hi Gary, the files are attached.

Gary Poster (gary)
Changed in launchpad:
assignee: Huw Wilkins (huwshimi) → Gary Poster (gary)
Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 740631] Re: mute and umute bug subscription doesn't change icon

I don't think that's going to work well for color blind users.

(Data welcome.) I didn't see the cross out on the first look, so it's really
on the color that distinguishes them.

Is the colored circle absolutely necessary?
On May 30, 2011 1:45 PM, "Huw Wilkins" <email address hidden> wrote:
> Hi Gary, the files are attached.
>
> ** Attachment added: "mute.tar.gz"
>
 https://bugs.launchpad.net/launchpad/+bug/740631/+attachment/2147333/+files/mute.tar.gz
>
> --
> You received this bug notification because you are subscribed to
> Launchpad itself.
> https://bugs.launchpad.net/bugs/740631
>
> Title:
> mute and umute bug subscription doesn't change icon

Revision history for this message
Robert Collins (lifeless) wrote :

At least for me I can indeed tell them apart.

Revision history for this message
Данило Шеган (danilo) wrote :

FWIW, the cross itself makes it look garbled for me, at least in the initial impression. Only after a second or two I realized that it was envelope with a line over it. For me, it'd work better if it had no cross over (red is 'negative' already), though I agree that'd be harmful for colour blind users.

As to ideas on how could we improve them, I definitely agree it's a hard problem, especially for the unmute action (negative of an already negative action, sounds like fun, since it's not really a positive action, which would be "subscribing"). Perhaps the mute action could instead take the shape of a hexagon resembling the "Stop" sign with the envelope in the middle? Not saying it'd be possible to fit it in 14px.

Revision history for this message
Данило Шеган (danilo) wrote :

And there's always the @ symbol that'd work better with crossing, I guess.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in db-stable r10639 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/10639>.

tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
Gary Poster (gary)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.