Launchpad itself

Code review comment for lp:~gary/launchpad/bug724609

  1. bug724609
  2. Merge into devel
Revision history for this message
Brad Crittenden (bac) wrote :

Hi Gary,

Thanks for this branch and helping to kill of windmill.

* As discussed on IRC, I think waitForIFrame is a bit misleading for a name but I've not got a reasonable suggestion for fixing it.

* When calling waitForIFrame it would be helpful to comment the arguments being passed. I needed to go back and forth to understand what was being passed. Trivial point.

* fix: """{Describe your test suite here}."""

Very nice branch.

review: Approve

« Back to merge proposal