Merge lp:~gary/juju-gui/styling-environment-menu into lp:juju-gui/experimental
Proposed by
Gary Poster
Status: | Merged |
---|---|
Merged at revision: | 882 |
Proposed branch: | lp:~gary/juju-gui/styling-environment-menu |
Merge into: | lp:juju-gui/experimental |
Diff against target: |
208 lines (+55/-34) 2 files modified
app/views/topology/service.js (+28/-11) lib/views/stylesheet.less (+27/-23) |
To merge this branch: | bzr merge lp:~gary/juju-gui/styling-environment-menu |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju GUI Hackers | Pending | ||
Review via email: mp+175973@code.launchpad.net |
Description of the change
Update service menus and enable for inspector
One of the last big issues remaining in the UX design to make the inspector usable was to make a disoverable way of creating relations. Luca and Ant worked together to revamp the existing popup menu for the purpose. This branch takes their design work and makes it work for both inspector and non-inspector uses. In order to have it work well, I had to update some of the calculations that determined where the menu was drawn.
To post a comment you must log in.
Reviewers: mp+175973_ code.launchpad. net,
Message:
Please take a look.
Description:
Update service menus and enable for inspector
One of the last big issues remaining in the UX design to make the
inspector usable was to make a disoverable way of creating relations.
Luca and Ant worked together to revamp the existing popup menu for the
purpose. This branch takes their design work and makes it work for both
inspector and non-inspector uses. In order to have it work well, I had
to update some of the calculations that determined where the menu was
drawn.
https:/ /code.launchpad .net/~gary/ juju-gui/ styling- environment- menu/+merge/ 175973
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/11620043/
Affected files: images/ icons/icon_ noshadow_ destroy. png images/ icons/icon_ noshadow_ relation. png images/ icons/icon_ noshadow_ view.png images/ landscape_ restart_ menu.png images/ landscape_ security_ menu.png topology/ service. js stylesheet. less
A [revision details]
M app/assets/
M app/assets/
M app/assets/
M app/assets/
M app/assets/
M app/views/
M lib/views/
Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>
Index: app/assets/ images/ icons/icon_ noshadow_ destroy. png images/ icons/icon_ noshadow_ destroy. png' images/ icons/icon_ noshadow_ destroy. png 2012-09-20 images/ icons/icon_ noshadow_ destroy. png
=== modified file 'app/assets/
Binary files app/assets/
15:53:46 +0000 and app/assets/
2013-07-19 16:03:37 +0000 differ
Index: app/assets/ images/ icons/icon_ noshadow_ relation. png images/ icons/icon_ noshadow_ relation. png' images/ icons/icon_ noshadow_ relation. png 2012-09-20 images/ icons/icon_ noshadow_ relation. png
=== modified file 'app/assets/
Binary files app/assets/
15:53:46 +0000 and app/assets/
2013-07-19 16:03:37 +0000 differ
Index: app/assets/ images/ icons/icon_ noshadow_ view.png images/ icons/icon_ noshadow_ view.png' images/ icons/icon_ noshadow_ view.png 2012-09-20 images/ icons/icon_ noshadow_ view.png
=== modified file 'app/assets/
Binary files app/assets/
15:53:46 +0000 and app/assets/
2013-07-20 01:15:05 +0000 differ
Index: app/assets/ images/ landscape_ restart_ menu.png images/ landscape_ restart_ menu.png' images/ landscape_ restart_ menu.png 2013-02-27 images/ landscape_ restart_ menu.png 2013-07-20
=== modified file 'app/assets/
Binary files app/assets/
14:49:14 +0000 and app/assets/
01:15:05 +0000 differ
Index: app/assets/ images/ landscape_ security_ menu.png images/ landscape_ security_ menu.png' images/ landscape_ security_ menu.png 2013-03-26 images/ landscape_ security_ menu.png 2013-07-20
=== modified file 'app/assets/
Binary files app/assets/
21:13:04 +0000 and app/assets/
01:15:05 +0000 differ
Index: app/views/ topology/ service. js topology/ service. js' topology/ service. js 2013-07-16 19:10:36 +0000 topology/ service. js 2013-07-20 01:19:53 +0000
=== modified file 'app/views/
--- app/views/
+++ app/views/
@@ -1196,12 +1196,14 @@
z = topo...