Code review comment for lp:~gary/juju-gui/fixsavetext

Revision history for this message
Jeff Pihach (hatch) wrote :

Looking good but there is some duplication of work, plz see below.

https://codereview.appspot.com/13505044/diff/1/app/views/inspector.js
File app/views/inspector.js (right):

https://codereview.appspot.com/13505044/diff/1/app/views/inspector.js#newcode1047
app/views/inspector.js:1047: if (!this.modifiedKeys) {
When a user changes the value of an input the databinding engine keeps
track of these changes via it's _storeChanged method on line 609 of
databinding.js. This method keeps track of these changes in each
viewlets _changedvalues method. It would be nice if you could use this
data set instead of trying to keep track of it yourself. If you need
reference to these values in this changed method you may need to pass it
into the method call on line 622.

https://codereview.appspot.com/13505044/

« Back to merge proposal