juju-gui

Merge lp:~gary/juju-gui/bug1218888 into lp:juju-gui/experimental

  1. bug1218888
  2. Merge into trunk
Proposed by Gary Poster
Status: Merged
Merged at revision: 1134
Proposed branch: lp:~gary/juju-gui/bug1218888
Merge into: lp:juju-gui/experimental
Diff against target: 12 lines (+1/-1)
1 file modified
Makefile (+1/-1)
To merge this branch: bzr merge lp:~gary/juju-gui/bug1218888
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+190977@code.launchpad.net

Description of the change

Produce xz distribution tarballs

Per https://codereview.appspot.com/14425057 , change the GUI to produce xz files. See the QA in the other proposal.

https://codereview.appspot.com/14494056/

To post a comment you must log in.
Revision history for this message
Gary Poster (gary) wrote :

Reviewers: mp+190977_code.launchpad.net,

Message:
Please take a look.

Description:
Produce xz distribution tarballs

Per https://codereview.appspot.com/14425057 , change the GUI to produce
xz files. See the QA in the other proposal.

https://code.launchpad.net/~gary/juju-gui/bug1218888/+merge/190977

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/14494056/

Affected files (+3, -1 lines):
   M Makefile
   A [revision details]

Index: Makefile
=== modified file 'Makefile'
--- Makefile 2013-10-12 01:30:26 +0000
+++ Makefile 2013-10-14 14:43:48 +0000
@@ -95,7 +95,7 @@
  LAUNCHPAD_API_ROOT=staging
  endif
  RELEASE_NAME=juju-gui-$(RELEASE_VERSION)
-RELEASE_FILE=releases/$(RELEASE_NAME).tgz
+RELEASE_FILE=releases/$(RELEASE_NAME).xz
  RELEASE_SIGNATURE=releases/$(RELEASE_NAME).asc
  NPM_CACHE_VERSION=$(BZR_REVNO)
  NPM_CACHE_FILE=$(CURDIR)/releases/npm-cache-$(NPM_CACHE_VERSION).tgz

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Revision history for this message
Brad Crittenden (bac) wrote :

LGTM. (Which always reminds me of the "baseball been berry berry good
to me" SNL skit. Perhaps we should support LBBGTM as approval.)

https://codereview.appspot.com/14494056/

Revision history for this message
Gary Poster (gary) wrote :

*** Submitted:

Produce xz distribution tarballs

Per https://codereview.appspot.com/14425057 , change the GUI to produce
xz files. See the QA in the other proposal.

R=bac
CC=
https://codereview.appspot.com/14494056

https://codereview.appspot.com/14494056/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2013-10-12 01:30:26 +0000
3+++ Makefile 2013-10-14 15:02:13 +0000
4@@ -95,7 +95,7 @@
5 LAUNCHPAD_API_ROOT=staging
6 endif
7 RELEASE_NAME=juju-gui-$(RELEASE_VERSION)
8-RELEASE_FILE=releases/$(RELEASE_NAME).tgz
9+RELEASE_FILE=releases/$(RELEASE_NAME).xz
10 RELEASE_SIGNATURE=releases/$(RELEASE_NAME).asc
11 NPM_CACHE_VERSION=$(BZR_REVNO)
12 NPM_CACHE_FILE=$(CURDIR)/releases/npm-cache-$(NPM_CACHE_VERSION).tgz

Subscribers

People subscribed via source and target branches