https://codereview.appspot.com/14565044/diff/1/app/models/charm.js#newcode468
app/models/charm.js:468: value.sort(function(a, b) {
This all looks great but I'm curious what this sort method gets you over
the standard lexicographic sort. You may also want to add this comment
to the code so others know when looking at this.
LGTM QA OK with trivial
https:/ /codereview. appspot. com/14565044/ diff/1/ app/models/ charm.js
File app/models/charm.js (right):
https:/ /codereview. appspot. com/14565044/ diff/1/ app/models/ charm.js# newcode466 charm.js: 466: setter: function(value) {
app/models/
you can quote this instead of commenting it if you like.
https:/ /codereview. appspot. com/14565044/ diff/1/ app/models/ charm.js# newcode468 charm.js: 468: value.sort( function( a, b) {
app/models/
This all looks great but I'm curious what this sort method gets you over
the standard lexicographic sort. You may also want to add this comment
to the code so others know when looking at this.
https:/ /codereview. appspot. com/14565044/