Merge lp:~gary/juju-gui/adjustCHANGES into lp:juju-gui/experimental

Proposed by Gary Poster
Status: Merged
Merged at revision: 1185
Proposed branch: lp:~gary/juju-gui/adjustCHANGES
Merge into: lp:juju-gui/experimental
Diff against target: 134 lines (+79/-33)
2 files modified
CHANGES.yaml (+50/-33)
docs/process.rst (+29/-0)
To merge this branch: bzr merge lp:~gary/juju-gui/adjustCHANGES
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+191891@code.launchpad.net

Description of the change

Adjust 0.11.0 change log

Also document an approach to generating the change log.

https://codereview.appspot.com/14990046/

To post a comment you must log in.
Revision history for this message
Gary Poster (gary) wrote :

Reviewers: mp+191891_code.launchpad.net,

Message:
Please take a look.

Description:
Adjust 0.11.0 change log

Also document an approach to generating the change log.

https://code.launchpad.net/~gary/juju-gui/adjustCHANGES/+merge/191891

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/14990046/

Affected files (+81, -33 lines):
   M CHANGES.yaml
   A [revision details]
   M docs/process.rst

Revision history for this message
Jeff Pihach (hatch) wrote :

LGTM Thanks for this update!

https://codereview.appspot.com/14990046/

lp:~gary/juju-gui/adjustCHANGES updated
1147. By Gary Poster

merge trunk

Revision history for this message
Gary Poster (gary) wrote :

*** Submitted:

Adjust 0.11.0 change log

Also document an approach to generating the change log.

R=jeff.pihach
CC=
https://codereview.appspot.com/14990046

https://codereview.appspot.com/14990046/

Revision history for this message
Gary Poster (gary) wrote :

Thanks for the review of the old branch, Jeff. I apparently forgot to
land it. :-/

https://codereview.appspot.com/14990046/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CHANGES.yaml'
2--- CHANGES.yaml 2013-10-17 23:01:01 +0000
3+++ CHANGES.yaml 2013-11-06 21:25:08 +0000
4@@ -23,40 +23,57 @@
5 - unreleased:
6 - 0.11.0:
7 - >
8- (FIX) Greatly reduced the size of the GUI release through removing
9- unnecessary bits and using more efficient compression. This will help
10- speed deployment greatly.
11- - Add onboarding beyond flag.
12- - >
13- Bundle display now includes charm icons in bundle detail page and on
14- token, the charms tab, the visualization caption with show/hide, icons,
15- and README, all visible via URLs. Bundles integraded in charm-browser
16- search results. All remains behind charmworldv3 feature flag.
17- - New import/export icons with hover/click.
18- - >
19- (FIX) Reported issue with export and inspector broken after a scripted
20- deploy.
21- - (FIX) Relation names now contain both endpoints.
22- - >
23- (FIX,CLEANUP) Coordinates were being stored in three places, causing
24- interesting side effects in a real environment. This was fixed along
25- with a refactor of coordinate managing code.
26- - (FIX) Export no longer sets number of units for subordinates.
27- - (FIX) Gracefully handle bundles without x/y annotated coordinates
28- - (FIX) Scale up input was disabled after value change.
29+ The inspector (and the GUI, for the first time) supports upgrading or
30+ downgrading a service's charm.
31+ - >
32+ The masthead's UX is improved, notably giving a bit more room for the
33+ rest of the application.
34+ - Relations now display the names of both endpoints in the environment.
35+ - >
36+ The GUI distribution is now about 1/9 the size it was before, speeding
37+ up deployment.
38+ - >
39+ Recommended charms (and bundles) are now marked with a red triangle,
40+ per results from UX tests.
41+ - >
42+ (FIX, CLEANUP) Service coordinates were being stored in three places,
43+ leading to confusion and bugs. This code was refactored, introducing
44+ many fixes to our service positioning behavior.
45+ - >
46+ (FIX) If the charm browser were fully open to show charm details, and
47+ the browser was minimized and then reopened, the details page would be
48+ blank.
49+ - >
50+ (FIX) The Go implementation of the sandbox always lost the first delta
51+ from the AllWatcher's Next method.
52+ - >
53+ (FIX) Bundle export should not include the number of units for
54+ subordinates.
55+ - (FIX) Inspector scale up input was disabled forever after value change.
56 - (FIX) Charm details link was not working correctly from inspector.
57- - >
58- (FIX) Go sandbox's AllWatcher initialization was broken, causing the
59- first change to go unnoticed.
60- - Position annotations added to export.
61- - The ability to upgrade a charm released without a feature flag.
62- - (FIX) Clarify that the charm has been processed in the source tab.
63- - (FIX) Fullscreen charm details tabs were loading above content.
64- - (FIX) Better listing of source file listing icons.
65- - (FIX) New units added to the canvas no longer overlap old ones
66- - >
67- (FIX) Minimizing the browser with the details view open; closing,
68- and then re-opening caused the browser to be blank.
69+ - (FIX) Unit details did not display exposed URL links properly.
70+ - (FIX) Position annotations are once again included in exports.
71+ - (FIX) New units added to the canvas no longer overlap old ones.
72+ - >
73+ (FIX) The charm "code" tab in the charm browser now sorts filenames by
74+ directory and name, to make it easier to find a particular file. It
75+ also excludes the svg files from the list, since the rendering was less
76+ than valuable.
77+ - >
78+ (CHARM FIX) This is actually a fix in the charm, but it is an important
79+ one that is worth calling out. In some environments, the GUI would
80+ break, not allowing proper inspection, export, or other basic behavior.
81+ This turned out to be because the new server had an issue with non-ascii
82+ values in some cases.
83+ - >
84+ Behind the "charmworldv3" flag, bundle support is ready for
85+ demonstration, including browsing and deploying, in the sandbox and in a
86+ live environment. Tweaks, bug fixes, and some approved bundles should
87+ take us the rest of the way soon. This comprised a very large portion
88+ of the work behind this release.
89+ - >
90+ Behind the "onboard" flag, the GUI has work to show helpful onboarding
91+ for new users.
92 - 0.10.1:
93 - Add icon for exporting a bundle.
94 - (FIX) The GUI was unusable when cookies were turned off in your browser.
95
96=== modified file 'docs/process.rst'
97--- docs/process.rst 2013-10-14 12:36:47 +0000
98+++ docs/process.rst 2013-11-06 21:25:08 +0000
99@@ -155,6 +155,35 @@
100 ``bzr commit -m 'Set version for release.'``
101 - Push the branch directly to the parent (``bzr push :parent`` should work).
102
103+- Verify that the section in ``CHANGES.yaml`` for the new release has the
104+ expected changelog news items, using the format described in the file. If
105+ you suspect that the changelog does not adequately describe what we
106+ accomplished since the last release, do the following.
107+
108+ - First, relax. This is a matter of art. Do your best, and focus on the
109+ end user. These instructions will ask you to make tons of judgements. Go
110+ for it. :-)
111+ - Identify the tag of the last release. This should usually be a three-part
112+ identifier such as the one you made in the bzr tag above. If you are not
113+ sure of the tags, try the bzr "tags" command, e.g. ``bzr tags`` or (for
114+ less cruft) ``bzr tags -r date:2013-10-17..``.
115+ - Look at the logs since the last release tag. If the last release tag was
116+ 0.11.0, for instance, use ``bzt log -r tag:'0.11.0'..``. You might want
117+ to pipe this output through less or something similar.
118+ - Review each commit from those logs. If the commit represents a new
119+ feature or fix that is interesting to end users, add a bullet for it in
120+ the changelog for this release.
121+ - Features should come first, working approximately from the features
122+ that are most compelling to end users down to the least.
123+ - Fixes should come next. Prefix fixes with "(FIX)" so they are clearly
124+ marked. Sometimes the difference between a feature and a fix is hard to
125+ gauge. Think about it from the perspective of the end user and make your
126+ best shot. Put big fixes first.
127+ - Flagged, unreleased features come last. Mention the feature flag first
128+ ('Behind the "charmworldv3" flag, ...') and then summarize progress. Even
129+ if many commits were behind a feature flag, just have a single bullet
130+ describing what we accomplished and, perhaps, what remains.
131+
132 - Run the tests and verify they pass: ``make test-prod`` and then
133 ``make test-debug``.
134 - Create the tarball: ``FINAL=1 make distfile``. The process will end by

Subscribers

People subscribed via source and target branches