Code review comment for lp:~gary/charms/precise/juju-gui/credentialConfig

Revision history for this message
Gary Poster (gary) wrote :

Reviewers: mp+188670_code.launchpad.net,

Message:
Please take a look.

Description:
Add password option to charm

In order to support ecosystems work, add a password option that lets the
charm pre-fill the password in the GUI.

To QA, start up the charm, and verify that you need to enter your
password in the GUI. Do not log in, or if you do, log out afterwards.
Next, juju set juju-gui password=[YOUR ADMIN SECRET] and wait about 20
seconds for the charm to reconfigure itself. Then go to the browser
again and you should not have to log in.

https://code.launchpad.net/~gary/charms/precise/juju-gui/credentialConfig/+merge/188670

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/14226043/

Affected files (+333, -16 lines):
   M Makefile
   A [revision details]
   M config.yaml
   M hooks/backend.py
   A hooks/charmhelpers.py
   M hooks/install
   M hooks/utils.py
   M tests/00-setup
   M tests/test_utils.py

« Back to merge proposal