Merge lp:~gary-wzl77/unity8/interactive_property into lp:unity8

[Gary.Wang]

Add widgetData["interactive"] property for image and gallery widgets.

Define widgetData["interactive"] property to make it possible to disable image and gallery popup up overlay/slideview when clicking.

* Are there any related MPs required for this MP to build/function as expected? Please list.
  No related MPs for this MP.
* Did you perform an exploratory manual test run of your code change and any related functionality?
  Yes, I do.
* Did you make sure that your branch does not contain spurious tags?
  No spurious tags.
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
  No packaging changed.
* If you changed the UI, has there been a design review?
  No UI changed.

[Albert Astals Cid (aacid)]

Hi there, what's the rationale for this?

It will confuse our users that will try to tap on the image to make it bigger and will think they found a bug.

What's the benefit of merging this?

review: Needs Information

[Gary.Wang (gary-wzl77)]

Personally, I think it doesn't make scene in most cases.
To take a trivial instance, weather scope. When user enter preview page,
clicking a thumbnail looks weird since there is no more detailed info user
can get when overlay layer popups.
In some practical cases, server only give us a low resolution image, so
clicking it to popup overlay layer looks terrible(image scaling) in that
case.

I think there's two cases for overlay display.
1.If image itself is big image(high-resolution), e.g photo scope. That
makes scene since user can check more details in overlay layer by
pinch/zoom-in/zoom-out.
2.showing low-resolution image in preview page and loading high-resolution
image when overlay layer popup looks more reasonable, however we can't make
sure there is always a high-resolution image url returned from server API.
It depends.

Basically I think there's no harm to add a property for this since we
didn't disable it to make it bigger to display.Developer can adjust bigger
image display in different scenario.

On Tue, Aug 4, 2015 at 10:26 PM, Albert Astals Cid <
<email address hidden>> wrote:

> Review: Needs Information
>
> Hi there, what's the rationale for this?
>
> It will confuse our users that will try to tap on the image to make it
> bigger and will think they found a bug.
>
> What's the benefit of merging this?
> --
>
> https://code.launchpad.net/~gary-wzl77/unity8/interactive_property/+merge/266732
> You are the owner of lp:~gary-wzl77/unity8/interactive_property.
>

--
Br
Gary.Wzl

[Albert Astals Cid (aacid)]

I've passed your comments through design, they see your point but are also potentially scared of inconsistencies, they'll come back to us with a decision on this "soon".

[Albert Astals Cid (aacid)]

I've opened a bug at https://bugs.launchpad.net/ubuntu-ux/+bug/1486071 and will set this to work in progress for the moment to clear the queue

Unmerged revisions

1900. By Gary.Wang on 2015-08-03

Add widgetData["interactive"] property for image and gallery widgets.

Define widgetData["interactive"] property to make it possible to
disable image and gallery popup up overlay/slideview when clicking.

=== modified file 'qml/Dash/Previews/PreviewImageGallery.qml'
--- qml/Dash/Previews/PreviewImageGallery.qml	2015-05-06 15:05:06 +0000
+++ qml/Dash/Previews/PreviewImageGallery.qml	2015-08-03 14:36:27 +0000
@@ -20,7 +20,10 @@
 
 /*! This preview widget shows a horizontal list of images.
  *  The URIs for the images should be an array in widgetData["sources"].
- *  Images fall back to widgetData["fallback"] if loading fails
+ *  Images fall back to widgetData["fallback"] if loading fails.
+ * 
+ *  It will popup a slideview when widgetData["interactive"] == true
+ *  and it's enabled by default.
  */
 
 PreviewWidget {
@@ -29,6 +32,9 @@
 
     property Item rootItem: QuickUtils.rootItem(root)
 
+    property bool interactive: root.widgetData["interactive"] === undefined ? 
+                                        true: root.widgetData["interactive"];
+
     ListView {
         id: previewImageListView
         objectName: "previewImageListView"
@@ -67,6 +73,8 @@
             MouseArea {
                 id: mouseArea
                 anchors.fill: parent
+                enabled: root.interactive;
+                
                 onClicked: {
                     previewImageListView.currentIndex = index;
                     overlay.updateInitialItem();
 
=== modified file 'qml/Dash/Previews/PreviewZoomableImage.qml'
--- qml/Dash/Previews/PreviewZoomableImage.qml	2015-05-06 15:05:06 +0000
+++ qml/Dash/Previews/PreviewZoomableImage.qml	2015-08-03 14:36:27 +0000
@@ -23,6 +23,9 @@
     This widget shows image contained in widgetData["source"],
     and falls back to widgetData["fallback"] if loading fails
     can be zoomable accordingly with widgetData["zoomable"].
+    
+    It will popup a overlay when widgetData["interactive"] == true
+    and it's enabled by default.
  */
 
 PreviewWidget {
@@ -31,6 +34,9 @@
 
     property Item rootItem: QuickUtils.rootItem(root)
 
+    property bool interactive: root.widgetData["interactive"] === undefined ?
+                                    true: root.widgetData["interactive"];
+
     LazyImage {
         id: lazyImage
         objectName: "lazyImage"
@@ -48,6 +54,8 @@
         MouseArea {
             id: mouseArea
             anchors.fill: parent
+            enabled: root.interactive;
+
             onClicked: {
                 overlay.initialX = rootItem.mapFromItem(parent, 0, 0).x;
                 overlay.initialY = rootItem.mapFromItem(parent, 0, 0).y;