Merge lp:~gary-wzl77/squid/snap_package into lp:squid/3.5
Status: | Rejected |
---|---|
Rejected by: | Amos Jeffries |
Proposed branch: | lp:~gary-wzl77/squid/snap_package |
Merge into: | lp:squid/3.5 |
Diff against target: |
584 lines (+409/-8) 13 files modified
README.snap (+29/-0) configure.ac (+10/-0) snap/snapcraft.yaml (+83/-0) snap/src/squid/conf/squid.conf.template (+116/-0) snap/src/squid/script/run-squid (+52/-0) snap/src/squid/script/settings (+39/-0) src/cache_cf.cc (+6/-0) src/cf_gen_defines (+1/-0) src/errorpage.cc (+8/-2) src/ipc/mem/Segment.cc (+16/-0) src/main.cc (+20/-4) src/mime.cc (+7/-1) src/tools.cc (+22/-1) |
To merge this branch: | bzr merge lp:~gary-wzl77/squid/snap_package |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Amos Jeffries | Disapprove | ||
Alex Rousskov | Disapprove | ||
Review via email: mp+318302@code.launchpad.net |
Commit message
Enable to package and compile squid in snap world.
1.Added conditional for snap packaging by testing "--enable-snap".
As all services run as root thanks to confinement in snap world,
so we need to get rid of uid, gid configured,
otherwise there will be bunch of apparmor DENIED issue when running
this snap in confined mode.
2.Fixed bunch of critical conf file reading path.
3.Make sure writeable path for some file reading. e.g pidfile
4.Make sure sem_open available inside snap. see
https:/
Description of the change
Enable to package and compile squid in snap world.
1.Added conditional for snap packaging by testing "--enable-snap".
As all services run as root thanks to confinement in snap world,
so we need to get rid of uid, gid configured,
otherwise there will be bunch of apparmor DENIED issue when running
this snap in confined mode.
2.Fixed bunch of critical conf file reading path.
3.Make sure writeable path for some file reading. e.g pidfile
4.Make sure sem_open available inside snap. see
https:/
This PR is still using the master branch as squid source in snapraft.yaml file.
As a PR, I don't change it as it targets to merge into master.
You can simply make a change as following to use my branch for testing purpose for the time being.
http://
Unmerged revisions
- 14144. By Gary.Wang
-
Enable to package and compile squid in snap world.
1.Added conditional for snap packaging by testing "--enable-snap".
As all services run as root thanks to confinement in snap world,
so we need to get rid of uid, gid configured,
otherwise there will be bunch of apparmor DENIED issue when running
this snap in confined mode.
2.Fixed bunch of critical conf file reading path.
3.Make sure writeable path for some file reading. e.g pidfile
4.Make sure sem_open available inside snap. see
https://bugs.launchpad .net/snappy/ +bug/1653955
The patch or bundle should probably be posted and discussed on squid-dev mailing list rather than here.
FWIW, I am against the proposed "let's sprinkle the code with snap-only hacks and add a bunch of snap-only files that developers will have to somehow maintain" approach. I hope this work can be refactored into two pieces:
1. A stand-alone package with a custom Squid configuration file template (if really needed) and possibly snap-specific Squid build options. The Squid Project will not maintain this package but official Squid documentation can refer to it.
2. A _minimum_ set of generally-useful Squid changes that make #1 possible. These changes will be committed and maintained by the Squid Project, of course. This should be done without adding a single monolithic set of options tied to the snap environment.