Code review comment for lp:~gary-wzl77/scope-aggregator/fix_1490828

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Hi Gary,

I did not understand that you want *every* keyword child scope to have a link to child.

So, I think we have discussed this enough. :)

You understand my preference to reuse and expand existing features and json keys where possible.

But if that does not meet the particular requirements, then please go ahead and complete the implementation as you have described, including the exclude_scopes key and I will approve after normal review.

cheers,
Kyle

« Back to merge proposal