Code review comment for lp:~gary-wzl77/scope-aggregator/default_query_string_And_only_in_search

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Hi Gary.

Small format/style request 1):
Please add a space after the "&&" in this line:
if (query_string.empty() &&scope->only_in_search() == true)

Style request 2):
Please use four spaces instead of tabs in this project. For example indentation looks wrong on line 110 below.

Most new features need to be documented in the README.md. Do you think this does?

Please refresh the branch here and I will approve.

Thanks,
Kyle

review: Needs Fixing

« Back to merge proposal