Code review comment for lp:~gary-wzl77/news-scope/fat_click_package

Revision history for this message
Gary.Wang (gary-wzl77) wrote :

Hi Kyle
Thanks for your question.

* is a single click package intended to contain the .so files for all architectures?
A: Yes, you're right, there's a single click package generated in following name convention after running make_click.sh
   ${PKG}_${SCOPE_NAME}_${VER_NUM}_multi.click
   the trailing string "_multi" indicates this click package contains binary files for all architectures which are declared in manifest.json.in
   ...
   "architecture": ["armhf", "arm64", "i386", "amd64"],
   ...

   As you can see, I added aggregator library(arm64) into a new folder(click-src/aggregator/aarch64-linux-gnu) and moved original armhf binary file into arm-linux-gnueabihf. That allows scope shell to load right binary file according to host architecture.
End user is able to install a single click package to all platform as long as the corresponding binary file can be found for each architecture.
This's how we support multi-architectures for all aggregator scope.

For each stand-alone scope, it's a little bit different.
I deploy a new script(build_fat_click.sh) for each scope.
https://bazaar.launchpad.net/~hanloon-team/hanloon/timeout/revision/52
you can use this script to generate fat click package as long as the declared architectures are created in your chroot.

P.S. You can still use previous way to generate armhf click. It's fine.
     Question: which kind of click we need to create and release on the store in the future, armhf or multi? Personally, I'd tend to the latter. Let's discuss with team members on this.

« Back to merge proposal