Code review comment for lp:~gary-lasker/software-center/lp1041004

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for your work on this branch.

I was a bit puzzled under what circumstances AppDetailsView.app_details can become None (because db.get_appdetails() always returns a != None value).

It turns out that the root cause is a race condition if the second appdetailsview
for the installed pane is initialized. https://bugs.launchpad.net/ubuntu/+source/software-center/+bug/1041004/comments/4 has the steps to reproduce. As this will cause other issues as well I created a branch:
lp:~mvo/software-center/fix-size-calc-race that fixes the race (a description of it is in the branch merge description) and as a side-effect fixes this bug here as well.

This is a similar issue as the one lp:~mvo/software-center/downloader-fix-race839462-again.

« Back to merge proposal