Code review comment for lp:~gary-lasker/software-center/fix-crash-lp969732

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for this branch!

It looks good, but I'm a bit puzzled why its needed there as AppTreeStore does not itself defines
__gsignals__ so it should set this up itself. I also can't reproduce this issue because of a bug in
ubuntu-sso-client currently. But I wonder if its maybe a order issue? And would love to know if:

=== modified file 'softwarecenter/ui/gtk3/models/appstore2.py'
--- softwarecenter/ui/gtk3/models/appstore2.py 2012-03-30 09:11:08 +0000
+++ softwarecenter/ui/gtk3/models/appstore2.py 2012-05-01 21:50:46 +0000
@@ -478,9 +478,9 @@

     def __init__(self, db, cache, icons, icon_size=AppGenericStore.ICON_SIZE,
                  global_icon_cache=True):
- AppGenericStore.__init__(
- self, db, cache, icons, icon_size, global_icon_cache)
         Gtk.TreeStore.__init__(self)
+ AppGenericStore.__init__(
+ self, db, cache, icons, icon_size, global_icon_cache)
         self.set_column_types(self.COL_TYPES)

     def set_documents(self, parent, documents):

works, i.e. just shuffling the __init__ around.

« Back to merge proposal