Code review comment for lp:~garrettdreyfus/scratch/encode-fix

Revision history for this message
Raphael Isemann (teemperor) wrote :

I missed two things:
"encoding.down()" should be "encoding.down ()" as there has to be a space before that opening-bracket.
Same goes for "new ConverterInputStream(" should be "new ConverterInputStream (".

I can't test it at the moment as i'm not on Isis (or my Luna install is broken), so you have to wait for someone else to review if your patch work as intended. I'll test otherwise tomorrow by myself :)

« Back to merge proposal