Code review comment for lp:~gang65/ubuntu-clock-app/ubuntu-clock-city-name-fix

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

* Does the MP add/remove user visible strings? If Yes, has the pot file been
    updated?

* Does the MP change the UI? If Yes, has it been approved by design?

No UI Changes.

* Did you perform an exploratory manual test run of your code change and any
    related functionality?

Yes, tested on N4, #95. All world city features work as expected!

* If the MP fixes a bug or implements a feature, are there accompanying unit
    and autopilot tests?

No accompanying unit test, but that is acceptable for now.

* Is the clock app trunk buildable and runnable using Qtcreator?

Yes

* Was the debian changelog updated?

Yes, but is causing a code conflict. Please fix the debian changelog and then top-approve when ready!

* Was the copyright years updated if necessary?

Yes, more than sufficiently ;)

review: Approve

« Back to merge proposal