Code review comment for lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-temporarly-result-fix

Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Have run the calculation manually on the phone as per this test:-

    def test_operation_on_large_numbers(self):
        self.app.main_view.insert('99999999999*99999999999=')
        self._assert_result_is(u'9.9999999998e+21')
        self._assert_history_contains(u'99999999999Γ—99999999999='
                                      '9.9999999998e+21')

        self.app.main_view.insert('*100=')

        self._assert_result_is(u'9.9999999998e+23')
        self._assert_history_contains(u'9.9999999998e+21Γ—100='
                                      '9.9999999998e+23')

I get 9.9999999998e+23 on the calculator in the store on my mx4.
I get 9.0000000998e+23 on this branch in on my bq phone.

So it seems the new library is a bit broken still.

« Back to merge proposal