Code review comment for lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-math-2.4-upgrade

Revision history for this message
Niklas Wenzel (nikwen) wrote :

Thank you for the patch, Bartosz! :)

I gave it a try and couldn't manage to find any regressions. :p I can confirm that the bug this is supposed to fix is indeed fixed and that the autopilot tests ran fine on my machine.
Looking at math.js's issue list on Github, I can also not find any regression in version 2.4 that would be relevant to our case.

Therefore, I'd say, let's get this in. :)

Good job, Bartosz!

review: Approve

« Back to merge proposal