Ubuntu Calculator App

Code review comment for lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-comma-without-number

  1. ubuntu-calculator-app-comma-without-number
  2. Merge into trunk
Revision history for this message
Niklas Wenzel (nikwen) wrote :

Thanks. This is one of the features I always missed!

I have a few minor complaints though. ;)
There is an issue related to the removed code from couldAddDot() now. Typing in '4!.2' results in '4!0.2' while in my opinion it should be '4!*0.2'. The same applies to 'pi.2'.
Also try the following: Type in '23,4', place the cursor after the three and type in a plus. Shouldn't it insert a zero?

Check out my inline comment below as well. ;)

Thanks again!

review: Needs Fixing

« Back to merge proposal