Code review comment for lp:~gang65/ubuntu-calculator-app/reboot_copy_selected_calculation

Revision history for this message
Giulio Collura (gcollura) wrote :

We can have two rightSideActions in ListItemWithActions, one action for copy another for favouring, because it can be tedious to start the selection mode, just to copy a single calculation. Anyway if this a design pattern and since I'm not a designer, I can't judge :)

I almost forgot, we have to filter out the entries in the model which have been hidden and have a dbId < 0, otherwise a empty calculation will be copied, if these get selected when selecting all the entries (I know this may be a bug in MultipleSelectionVisualModel, but it's better to workaround it here in this case). Just put a 'if (items.get(j).model.dbId !== -1)' before adding the calculations to mimeData.text.

Thank you!

Giulio

review: Needs Fixing

« Back to merge proposal