Merge lp:~gandelman-a/glance/lp828719 into lp:glance/diablo

Proposed by Adam Gandelman
Status: Needs review
Proposed branch: lp:~gandelman-a/glance/lp828719
Merge into: lp:glance/diablo
Diff against target: 46 lines (+2/-5)
2 files modified
Authors (+1/-0)
glance/common/config.py (+1/-5)
To merge this branch: bzr merge lp:~gandelman-a/glance/lp828719
Reviewer Review Type Date Requested Status
OpenStack Infra Pending
Review via email: mp+72773@code.launchpad.net

Description of the change

Resolves bug #828719, which can potentially cause problems depending on what $PWD commands are executed in.

To post a comment you must log in.

Unmerged revisions

206. By Adam Gandelman

Update Authors

205. By Adam Gandelman

Remove "." from list of possible config_file_dirs (LP #828719)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Authors'
--- Authors 2011-08-15 19:58:57 +0000
+++ Authors 2011-08-24 18:46:17 +0000
@@ -1,3 +1,4 @@
1Adam Gandelman <adamg@canonical.com>
1Andrey Brindeyev <abrindeyev@griddynamics.com>2Andrey Brindeyev <abrindeyev@griddynamics.com>
2Brian Lamar <brian.lamar@rackspace.com>3Brian Lamar <brian.lamar@rackspace.com>
3Brian Waldon <brian.waldon@rackspace.com>4Brian Waldon <brian.waldon@rackspace.com>
45
=== modified file 'glance/common/config.py'
--- glance/common/config.py 2011-08-11 20:15:33 +0000
+++ glance/common/config.py 2011-08-24 18:46:17 +0000
@@ -189,7 +189,6 @@
189 * If --config-file option is used, use that189 * If --config-file option is used, use that
190 * If args[0] is a file, use that190 * If args[0] is a file, use that
191 * Search for $app.conf in standard directories:191 * Search for $app.conf in standard directories:
192 * .
193 * ~.glance/192 * ~.glance/
194 * ~193 * ~
195 * /etc/glance194 * /etc/glance
@@ -207,8 +206,7 @@
207 return fix_path(args[0])206 return fix_path(args[0])
208207
209 # Handle standard directory search for $app_name.conf208 # Handle standard directory search for $app_name.conf
210 config_file_dirs = [fix_path(os.getcwd()),209 config_file_dirs = [fix_path(os.path.join('~', '.glance')),
211 fix_path(os.path.join('~', '.glance')),
212 fix_path('~'),210 fix_path('~'),
213 '/etc/glance/',211 '/etc/glance/',
214 '/etc']212 '/etc']
@@ -228,7 +226,6 @@
228 * If --config-file option is used, use that226 * If --config-file option is used, use that
229 * If args[0] is a file, use that227 * If args[0] is a file, use that
230 * Search for $app_name.conf in standard directories:228 * Search for $app_name.conf in standard directories:
231 * .
232 * ~.glance/229 * ~.glance/
233 * ~230 * ~
234 * /etc/glance231 * /etc/glance
@@ -264,7 +261,6 @@
264 * If --config-file option is used, use that261 * If --config-file option is used, use that
265 * If args[0] is a file, use that262 * If args[0] is a file, use that
266 * Search for $app_name.conf in standard directories:263 * Search for $app_name.conf in standard directories:
267 * .
268 * ~.glance/264 * ~.glance/
269 * ~265 * ~
270 * /etc/glance266 * /etc/glance

Subscribers

People subscribed via source and target branches

to all changes: