Merge lp:~gandelman-a/charms/precise/keystone/config-changed into lp:~charmers/charms/precise/keystone/trunk

Proposed by Adam Gandelman
Status: Merged
Approved by: Mark Mims
Approved revision: 32
Merge reported by: Adam Gandelman
Merged at revision: not available
Proposed branch: lp:~gandelman-a/charms/precise/keystone/config-changed
Merge into: lp:~charmers/charms/precise/keystone/trunk
Diff against target: 65 lines (+21/-2)
3 files modified
hooks/keystone-hooks (+5/-1)
hooks/utils.py (+15/-0)
revision (+1/-1)
To merge this branch: bzr merge lp:~gandelman-a/charms/precise/keystone/config-changed
Reviewer Review Type Date Requested Status
Mark Mims (community) Approve
Review via email: mp+118848@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Mark Mims (mark-mims) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'hooks/keystone-hooks'
--- hooks/keystone-hooks 2012-04-14 00:24:56 +0000
+++ hooks/keystone-hooks 2012-08-08 23:20:23 +0000
@@ -230,12 +230,16 @@
230 }230 }
231 relation_set(relation_data)231 relation_set(relation_data)
232232
233def config_changed():
234 ensure_initial_admin(config)
235
233hooks = {236hooks = {
234 "install": install_hook,237 "install": install_hook,
235 "shared-db-relation-joined": db_joined,238 "shared-db-relation-joined": db_joined,
236 "shared-db-relation-changed": db_changed,239 "shared-db-relation-changed": db_changed,
237 "identity-service-relation-joined": identity_joined,240 "identity-service-relation-joined": identity_joined,
238 "identity-service-relation-changed": identity_changed241 "identity-service-relation-changed": identity_changed,
242 "config-changed": config_changed
239}243}
240244
241# keystone-hooks gets called by symlink corresponding to the requested relation245# keystone-hooks gets called by symlink corresponding to the requested relation
242246
=== modified file 'hooks/utils.py'
--- hooks/utils.py 2012-03-02 20:46:20 +0000
+++ hooks/utils.py 2012-08-08 23:20:23 +0000
@@ -371,6 +371,7 @@
371 """371 """
372 create_tenant("admin")372 create_tenant("admin")
373 create_tenant(config["service-tenant"])373 create_tenant(config["service-tenant"])
374
374 passwd = ""375 passwd = ""
375 if config["admin-password"] != "None":376 if config["admin-password"] != "None":
376 passwd = config["admin-password"]377 passwd = config["admin-password"]
@@ -383,6 +384,7 @@
383 open(stored_passwd, 'w+').writelines("%s\n" % passwd)384 open(stored_passwd, 'w+').writelines("%s\n" % passwd)
384385
385 create_user(config['admin-user'], passwd, tenant='admin')386 create_user(config['admin-user'], passwd, tenant='admin')
387 update_user_password(config['admin-user'], passwd)
386 create_role(config['admin-role'], config['admin-user'], 'admin')388 create_role(config['admin-role'], config['admin-user'], 'admin')
387 # TODO(adam_g): The following roles are likely not needed since redux merge389 # TODO(adam_g): The following roles are likely not needed since redux merge
388 create_role("KeystoneAdmin", config["admin-user"], 'admin')390 create_role("KeystoneAdmin", config["admin-user"], 'admin')
@@ -395,3 +397,16 @@
395 internal_url = "http://%s:%s/v2.0" % (config["hostname"], config["service-port"])397 internal_url = "http://%s:%s/v2.0" % (config["hostname"], config["service-port"])
396 create_endpoint_template("RegionOne", "keystone", public_url,398 create_endpoint_template("RegionOne", "keystone", public_url,
397 admin_url, internal_url)399 admin_url, internal_url)
400
401def update_user_password(username, password):
402 import manager
403 manager = manager.KeystoneManager(endpoint='http://localhost:35357/v2.0/',
404 token=get_admin_token())
405 juju_log("Updating password for user '%s'" % username)
406
407 user_id = manager.resolve_user_id(username)
408 if user_id is None:
409 error_out("Could not resolve user id for '%s'" % username)
410
411 manager.api.users.update_password(user=user_id, password=password)
412 juju_log("Successfully updated password for user '%s'" % username)
398413
=== modified file 'revision'
--- revision 2012-03-08 22:38:36 +0000
+++ revision 2012-08-08 23:20:23 +0000
@@ -1,1 +1,1 @@
11381140

Subscribers

People subscribed via source and target branches