Charm Helpers

Code review comment for lp:~gandelman-a/charm-helpers/ha_os_cleanup

  1. ha_os_cleanup
  2. Merge into devel
Revision history for this message
James Page (james-page) wrote :

Hi Adam

Nice work!

Feedback:

1) hookenv.log as juju_log

Nice idea; however some calls have the level/message ordered incorrectly:

            juju_log('INFO', 'Deferring action to CRM leader.')

I found quite a few instances of this.

2) units.install/utils.restart

I found quite a bit of use of these two deprecated helpers; can we switch to using core.host now? Not sure whether that was meant to be in this branch or not.

3) ceph.py/haproxy.py

Is this still in use? Its using utils exclusively.

review: Needs Fixing

« Back to merge proposal