Great! I am completely fine to merge it as is now. There's only one minor point I missed the last time:
- passing const bool (int, int32_t...) into a function makes no sense - in fact, it makes little sense to pass anything by value as const. It is not your code, but could you fix this whenever you see it?
Please let me know if you want to fix this or not. If not, I will merge the change as is. If yes - Year!
Great! I am completely fine to merge it as is now. There's only one minor point I missed the last time:
- passing const bool (int, int32_t...) into a function makes no sense - in fact, it makes little sense to pass anything by value as const. It is not your code, but could you fix this whenever you see it?
Please let me know if you want to fix this or not. If not, I will merge the change as is. If yes - Year!