Merge lp:~gala-dev/gala/no-animate-depth into lp:gala

Proposed by Tom Beckmann
Status: Rejected
Rejected by: Sergey "Shnatsel" Davidoff
Proposed branch: lp:~gala-dev/gala/no-animate-depth
Merge into: lp:gala
Diff against target: 79 lines (+23/-7)
4 files modified
data/org.pantheon.desktop.gala.gschema.xml (+5/-0)
src/Plugin.vala (+13/-6)
src/Settings.vala (+1/-0)
src/Widgets/WindowSwitcher.vala (+4/-1)
To merge this branch: bzr merge lp:~gala-dev/gala/no-animate-depth
Reviewer Review Type Date Requested Status
Danielle Foré Disapprove
Sergey "Shnatsel" Davidoff (community) Needs Fixing
Review via email: mp+147558@code.launchpad.net

Description of the change

Adds an animate-depth key defaulting to false, which toggles the depth part of menu and alt-tab animations.

To post a comment you must log in.
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

This is better, but Slingshot still appears with a visual BOOM!

Also, I'm not sure why a GSettings key for this should be introduced. First, the name of the key is confusing, since it affects only some of the animations. Seconf, if these animations have superior usability, we should probably hardcode them - as per http://elementaryos.org/docs/avoid-configuration

review: Needs Fixing
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Also, this change does not affect the Slingshot closing animation.

Menu animations should probably be made faster, right now they're taking too long.

review: Needs Fixing
lp:~gala-dev/gala/no-animate-depth updated
297. By Tom Beckmann

Add menu destroy animation

Revision history for this message
Cody Garver (codygarver) wrote :

Really like this.

Revision history for this message
Cody Garver (codygarver) wrote :

On paper it sounds like a bad idea, but in execution it gives this feel of maturity to the desktop we haven't seen since gala itself was introduced. Not to mention it reduces visual glitches at Slingshot launch and most importantly it reduces visual lag when the system is under stress.

Revision history for this message
Danielle Foré (danrabbit) wrote :

Hrm. I don't really like it as much to be honest :/

Revision history for this message
Danielle Foré (danrabbit) wrote :

Tom and I talked about it and decided we were -1 to this particularly change. But we're open to discussing other ways to make the animations smoother.

review: Disapprove
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

The Lord has spoken. Amen.

Unmerged revisions

297. By Tom Beckmann

Add menu destroy animation

296. By Tom Beckmann

gsettings: add animate-depth key which toggles the depth part of the menu and window switcher animations, default is false

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/org.pantheon.desktop.gala.gschema.xml'
--- data/org.pantheon.desktop.gala.gschema.xml 2013-02-10 14:01:15 +0000
+++ data/org.pantheon.desktop.gala.gschema.xml 2013-02-10 17:48:21 +0000
@@ -128,6 +128,11 @@
128 </schema>128 </schema>
129 129
130 <schema path="/org/pantheon/desktop/gala/animations/" id="org.pantheon.desktop.gala.animations" gettext-domain="gala">130 <schema path="/org/pantheon/desktop/gala/animations/" id="org.pantheon.desktop.gala.animations" gettext-domain="gala">
131 <key type="b" name="animate-depth">
132 <default>false</default>
133 <summary>Enable depth in animations</summary>
134 <description>If this is set to true, the alt-tab-switcher and menu animation will animate with depth</description>
135 </key>
131 <key type="b" name="enable-animations">136 <key type="b" name="enable-animations">
132 <default>true</default>137 <default>true</default>
133 <summary>Enable Animations</summary>138 <summary>Enable Animations</summary>
134139
=== modified file 'src/Plugin.vala'
--- src/Plugin.vala 2013-02-10 13:37:14 +0000
+++ src/Plugin.vala 2013-02-10 17:48:21 +0000
@@ -464,8 +464,10 @@
464 464
465 actor.scale_gravity = Clutter.Gravity.CENTER;465 actor.scale_gravity = Clutter.Gravity.CENTER;
466 actor.rotation_center_x = {0, 0, 10};466 actor.rotation_center_x = {0, 0, 10};
467 actor.scale_x = 0.9f;467 if (AnimationSettings.get_default ().animate_depth) {
468 actor.scale_y = 0.9f;468 actor.scale_x = 0.9f;
469 actor.scale_y = 0.9f;
470 }
469 actor.opacity = 0;471 actor.opacity = 0;
470 actor.animate (Clutter.AnimationMode.EASE_OUT_QUAD, AnimationSettings.get_default ().menu_duration, 472 actor.animate (Clutter.AnimationMode.EASE_OUT_QUAD, AnimationSettings.get_default ().menu_duration,
471 scale_x:1.0f, scale_y:1.0f, opacity:255)473 scale_x:1.0f, scale_y:1.0f, opacity:255)
@@ -558,10 +560,15 @@
558 560
559 destroying.add (actor);561 destroying.add (actor);
560 562
561 actor.animate (Clutter.AnimationMode.EASE_OUT_QUAD, AnimationSettings.get_default ().menu_duration, 563 Clutter.Animation anim;
562 scale_x:0.8f, scale_y:0.8f, opacity:0)564 if (AnimationSettings.get_default ().animate_depth)
563 .completed.connect ( () => {565 anim = actor.animate (Clutter.AnimationMode.EASE_OUT_QUAD, AnimationSettings.get_default ().menu_duration,
564 566 scale_x:0.8f, scale_y:0.8f, opacity:0);
567 else
568 anim = actor.animate (Clutter.AnimationMode.EASE_OUT_QUAD, AnimationSettings.get_default ().menu_duration,
569 opacity : 0);
570
571 anim.completed.connect ( () => {
565 destroying.remove (actor);572 destroying.remove (actor);
566 destroy_completed (actor);573 destroy_completed (actor);
567 });574 });
568575
=== modified file 'src/Settings.vala'
--- src/Settings.vala 2013-02-10 14:01:15 +0000
+++ src/Settings.vala 2013-02-10 17:48:21 +0000
@@ -129,6 +129,7 @@
129 public class AnimationSettings : Granite.Services.Settings129 public class AnimationSettings : Granite.Services.Settings
130 {130 {
131 public bool enable_animations { get; set; }131 public bool enable_animations { get; set; }
132 public bool animate_depth { get; set; }
132 public int open_duration { get; set; }133 public int open_duration { get; set; }
133 public int snap_duration { get; set; }134 public int snap_duration { get; set; }
134 public int close_duration { get; set; }135 public int close_duration { get; set; }
135136
=== modified file 'src/Widgets/WindowSwitcher.vala'
--- src/Widgets/WindowSwitcher.vala 2013-02-10 14:01:15 +0000
+++ src/Widgets/WindowSwitcher.vala 2013-02-10 17:48:21 +0000
@@ -232,7 +232,10 @@
232 232
233 dock.get_child_at_index (i).animate (AnimationMode.LINEAR, 100, opacity : 255);233 dock.get_child_at_index (i).animate (AnimationMode.LINEAR, 100, opacity : 255);
234 } else {234 } else {
235 clone.animate (Clutter.AnimationMode.EASE_OUT_QUAD, 250, depth : -200.0f, opacity : 0);235 if (AnimationSettings.get_default ().animate_depth)
236 clone.animate (Clutter.AnimationMode.EASE_OUT_QUAD, 250, depth : -200.0f, opacity : 0);
237 else
238 clone.animate (Clutter.AnimationMode.EASE_OUT_QUAD, 250, opacity : 0);
236 dock.get_child_at_index (i).animate (AnimationMode.LINEAR, 100, opacity : 100);239 dock.get_child_at_index (i).animate (AnimationMode.LINEAR, 100, opacity : 100);
237 }240 }
238 241

Subscribers

People subscribed via source and target branches