Code review comment for ~gabrielzchen/plainbox-provider-resource:on-demand-support

Revision history for this message
Pierre Equoy (pieq) wrote :

First of all, thanks a lot for submitting this proposal and taking the time to explain the issue!

I agree with you, we need to discuss between the different teams to decide exactly what we should be testing once and for all.

Regarding your proposal, I know that `prime-select query` returns the current mode. Until now, we just assume the image is pre-installed with `prime-select` set at `intel`, but as you mention, on laptops, it's not the case anymore. You could update the script so that it checks for the current mode (using `prime-select query`), save this information (e.g. `initial_mode`), switch to `nvidia`, then switch back to `initial_mode`.

What do you think?

« Back to merge proposal