~gabrielcocenza/juju-lint:fix-setup

Branch merges

Propose for merging

Merged into juju-lint:master at revision 5ad8fb10b767a4443d815f015eafcaa49a16ef59

Ramesh Sattaru (community): Approve on 2022-12-05

Erhan Sunar (community): Approve on 2022-12-05

🤖 prod-jenkaas-bootstack (community): Approve (continuous-integration) on 2022-12-03

Diff: 10 lines (+1/-0)

1 file modified

setup.py (+1/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

80e073e... by Gabriel Cocenza on 2022-12-03

fix setup.py to include non python files

- add config_default.yaml into the snap package

1a1351f... by Marcus Boden on 2022-12-02

use values in config file

Values set in $HOME/.config/juju-lint/config.yaml were ignored, due to
the default values of the ArgumentParser. This patch
- removes the default values from the parser
- adds default values to the config_default.yaml
- adds tests to check if the config files are read correctly

Closes-Bug: #1939438

Reviewed-on: https://code.launchpad.net/~marcusboden/juju-lint/+git/juju-lint/+merge/433574
Reviewed-by: Martin Kalcok <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Gabriel Angelo Sgarbi Cocenza <email address hidden>
Reviewed-by: Erhan Sunar <email address hidden>

c57bb55... by Marcus Boden on 2022-12-02

removed unnecessary return and fixed two typos

fffc38c... by Marcus Boden on 2022-12-02

Change comment to regular funciton definition.

b30ed0b... by Gabriel Cocenza on 2022-12-01

add subdirectories and fixed functional tests

- fixed setup.py to accept subdirectories under the jujulint project
  folder.
- changed the working directory when running functional tests with
  the snap to not use local modules.
- updated contributing for func-smoke and func-dev to run functional
  tests during development.

Reviewed-on: https://code.launchpad.net/~gabrielcocenza/juju-lint/+git/juju-lint/+merge/433889
Reviewed-by: Erhan Sunar <email address hidden>
Reviewed-by: Eric Chen <email address hidden>
Reviewed-by: Tianqi Xiao <email address hidden>

36f4a66... by Gabriel Cocenza on 2022-11-30

add subdirectories and fixed functional tests

- fixed setup.py to accept subdirectories under the jujulint project
  folder.
- changed the working directory when running functional tests with
  the snap to not use local modules.
- updated contributing for func-smoke and func-dev to run functional
  tests during development.

493cc40... by Marcus Boden on 2022-12-01

Added cli-parsing tests and fixed some smaller issues

- config-file mocking packed into its own function.
- mocking argv to check if cli values are read
- makes sure test_default_config doesnt read user-config

e1874de... by Marcus Boden on 2022-11-24

Fixed unit tests

confuses only tries to read the .config/juju-lint/config.yaml, if it
exists. So I had to mock the os.path.isfile test for that file as well.

d775903... by Marcus Boden on 2022-11-23

use values in config file

Values set in $HOME/.config/juju-lint/config.yaml were ignored, due to
the default values of the ArgumentParser. This patch
- removes the default values from the parser
- adds default values to the config_default.yaml
- adds tests to check if the config files are read correctly

Closes-Bug: #1939438

18b2267... by Sudeep Bhandari on 2022-11-09

Apply snap template from bootstack-charms-spec

Reviewed-on: https://code.launchpad.net/~sudeephb/juju-lint/+git/juju-lint/+merge/432609
Reviewed-by: Robert Gildein <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Eric Chen <email address hidden>