~gabrielcocenza/juju-lint:bug/1988851

Last commit made on 2022-10-11
Get this branch:
git clone -b bug/1988851 https://git.launchpad.net/~gabrielcocenza/juju-lint
Only Gabriel Cocenza can upload to this branch. If you are Gabriel Cocenza please log in for upload directions.

Branch merges

Branch information

Name:
bug/1988851
Repository:
lp:~gabrielcocenza/juju-lint

Recent commits

d520551... by Gabriel Cocenza

check path_mtu values depending on the networking solution (ovs, ovn)

- added the possibility of adding custom messages and log level for
  config checks (isset, eq, neq, gte and search)

Closes-Bug: #1988851

9160dae... by Gabriel Cocenza

added new relation rule check for ubiquitous

- ubiquitous relation rule to ensure every machine has a charm unit on it.

- added ubiquitous relation rule to nrpe, telegraf, filebeat, landscape-client and ubuntu-advantage.

- added a new model input module that is responsible to differentiate the
  type of input (Juju Status, Juju Bundle). The input object encapsulate
  all mapping and queries necessary against a file.

Closes-Bug: #1893272

Reviewed-on: https://code.launchpad.net/~gabrielcocenza/juju-lint/+git/juju-lint/+merge/429919
Reviewed-by: Martin Kalcok <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>

5dc4c25... by Gabriel Cocenza

added new relation rule check for ubiquitous

- ubiquitous relation rule to ensure every machine has a charm unit on it.

- added ubiquitous relation rule to nrpe, telegraf, filebeat, landscape-client
  and ubuntu-advantage.

- added a new model input module that is responsible to differentiate the
  type of input (Juju Status, Juju Bundle). The input object encapsulate
  all mapping and queries necessary against a file.

Closes-Bug: #1893272

ce3bd98... by Mert Kirpici

Release 1.0.4

Reviewed-on: https://code.launchpad.net/~mertkirpici/juju-lint/+git/juju-lint/+merge/430400
Reviewed-by: Eric Chen <email address hidden>

7199fbe... by Mert Kirpici

docs: add release notes for 1.0.4

Signed-off-by: Mert Kırpıcı <email address hidden>

c05a391... by Mert Kirpici

Close LP #1989575

Reviewed-on: https://code.launchpad.net/~mertkirpici/juju-lint/+git/juju-lint/+merge/429879
Reviewed-by: Eric Chen <email address hidden>
Reviewed-by: Gabriel Angelo Sgarbi Cocenza <email address hidden>

1e67b7a... by Mert Kirpici

tox: separate requirements

The idea behind this change is to separate the requirements to avoid
installing redundant packages for each different testing/linting
environment that we are using during a regular development cycle.

Also now we are getting rid of preparing the dev-environment and
installing pre-commit via virtualenv and moving this operation inside
tox.ini which all the other virtual environments are residing, relieving
the Makefile of this duty.

After the renaming process in 30066d3b, makefile dev-environment target
was overlooked, ending up with the broken target. This change is fixing
that also.

Since this issue[0] is resolved, unpinned the flake8 version.

The .venv/ created by dev-environment was not ignored by git, fixed
that.

[0] https://github.com/csachs/pyproject-flake8/issues/13

Closes-bug: 1989575
Signed-off-by: Mert Kırpıcı <email address hidden>

d89eef7... by Mert Kirpici

Close LP #1987951

Reviewed-on: https://code.launchpad.net/~mertkirpici/juju-lint/+git/juju-lint/+merge/429025
Reviewed-by: Eric Chen <email address hidden>
Reviewed-by: Gabriel Angelo Sgarbi Cocenza <email address hidden>
Reviewed-by: Martin Kalcok <email address hidden>

ef16249... by Mert Kirpici

config: deprecate option --dump-state

Using two different command line arguments for the same feature was a
bit confusing. Especially the command line option --dump-state was used
as a boolean flag however it expected a no-op argument to be passed. The
new behavior will gladly accept any number of arguments including zero
and do nothing with them except for printing a deprecation notice.

Dumping the cloud state will be activated by the --output-dir option
only.

We move from this usage:
  $ juju-lint --dump-state NOOP_ARG --output-dir DIR ...

to this:
  $ juju-lint --output-dir DIR ...

Also during the investigation of this issue, another issue was observed.
This option suggests in its help text that the lint reports are also
going to be written to the output directory, however in the resulting
output they were absent. Another launchpad issue is filed about this and
the "lint reports" part is taken out of the help text for now, to not to
confuse the user.

This change also adds a check for the existence and write access to the
directory before running any linting.

Closes-bug: #1987951
Signed-off-by: Mert Kırpıcı <email address hidden>

e41480d... by Gabriel Cocenza

added new rule for checking relations.

Closes-Bug: #1965762, #1975548

Reviewed-on: https://code.launchpad.net/~gabrielcocenza/juju-lint/+git/juju-lint/+merge/427991
Reviewed-by: Martin Kalcok <email address hidden>