Merge ~gabrielcocenza/juju-lint:charm_not_recognize/BSENG-2093 into juju-lint:master

[Gabriel Cocenza]

Change loglevel of unrecognized charms from error to info

- error level currently generates too many false positives that hide actual
  errors in the bundle or the deployment.
- this might be a temporary solution until rules are updated to handle COS charms

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Samuel Allan (samuelallan)]

Could you update the commit message here with info about how this is desired as a temporary solution until COS support is ready in juju-lint, and that the false positives relate to extra COS-related charms deployed (I think this was the reason)?

[Samuel Allan (samuelallan)]

Ah I see now this info is in the linked bug report, by bad. I still think it could be good to have more information in the commit. :)

[Gabriel Cocenza (gabrielcocenza)]

> Ah I see now this info is in the linked bug report, by bad. I still think it
> could be good to have more information in the commit. :)

Good idea, I've changed to mention it

[Andrea Ieri (aieri)]

I've taken the liberty of tweaking the commit message, otherwise lgtm

review: Approve

[Tianqi Xiao (txiao)]

LGTM

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision ee96e76c8815e7f4d9e3abacb575ae4bdcc2060e

diff --git a/jujulint/lint.py b/jujulint/lint.py
index 8fa3f97..b40b00d 100755
--- a/jujulint/lint.py
+++ b/jujulint/lint.py
@@ -864,7 +864,8 @@ class Linter:
                         "description": "An unrecognised charm is present in the model",
                         "charm": charm,
                         "message": "Charm '{}' not recognised".format(charm),
-                    }
+                    },
+                    log_level=logging.INFO
                 )
         # Then look for charms we require
         for charm in self.lint_rules["operations mandatory"]:
diff --git a/tests/unit/test_jujulint.py b/tests/unit/test_jujulint.py
index b98474b..8d49cb1 100644
--- a/tests/unit/test_jujulint.py
+++ b/tests/unit/test_jujulint.py
@@ -352,9 +352,7 @@ applications:
         linter.do_lint(juju_status)
 
         errors = linter.output_collector["errors"]
-        assert len(errors) == 1
-        assert errors[0]["id"] == "unrecognised-charm"
-        assert errors[0]["charm"] == "ubuntu"
+        assert len(errors) == 0
 
     def test_ops_subordinate_missing(self, linter, juju_status):
         """Test that missing ops subordinate charms are detected."""