Merge ~gabrielcocenza/juju-lint:basepython into juju-lint:master

Proposed by Gabriel Cocenza
Status: Merged
Approved by: Mert Kirpici
Approved revision: 8a1aa54b03a3004ae13572116f3e621a35575390
Merged at revision: e115361cca6bb4e1148c0fdd91873ff7997deccb
Proposed branch: ~gabrielcocenza/juju-lint:basepython
Merge into: juju-lint:master
Diff against target: 13 lines (+1/-1)
1 file modified
tox.ini (+1/-1)
Reviewer Review Type Date Requested Status
Mert Kirpici (community) Approve
🤖 prod-jenkaas-bootstack continuous-integration Approve
BootStack Reviewers Pending
Review via email: mp+431700@code.launchpad.net

Commit message

basepython to python3

- Jenkins CI runs on jammy series and func tests are failing
  because of the python interpreter.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mert Kirpici (mertkirpici) wrote :

thanks for this Gabriel.

For visibility about the discussion we had, I am adding the side effects of this change.
The functional tests have two "modes of operation":
1 - installing the snap and running tests against the cli program provided by the snap
2 - installing the python package to the tox virtualenv and running the cli program provided by the python package.

This change will not have an effect on (1) since the snap is confined, however it will cause the mode (2) to run using the native python interpreter installed the environment which may be different than what the snap "core" has.
The CI system is operating in mode (1).

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision e115361cca6bb4e1148c0fdd91873ff7997deccb

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tox.ini b/tox.ini
2index ba747d8..4dea114 100644
3--- a/tox.ini
4+++ b/tox.ini
5@@ -16,7 +16,7 @@ envlist = lint, unit, func
6 skip_missing_interpreters = True
7
8 [testenv]
9-basepython = python3.8
10+basepython = python3
11
12 [testenv:unit]
13 deps =

Subscribers

People subscribed via source and target branches