Merge ~gabrielcocenza/juju-lint:bug/1978739 into juju-lint:master
Proposed by
Gabriel Cocenza
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Martin Kalcok | ||||||||
Approved revision: | 5160caab5760de907af591d05de6217405ef989a | ||||||||
Merged at revision: | ea3f3020a6e0d77cdb4ffc7f29d7f7ff3b9b112d | ||||||||
Proposed branch: | ~gabrielcocenza/juju-lint:bug/1978739 | ||||||||
Merge into: | juju-lint:master | ||||||||
Diff against target: |
450 lines (+144/-58) 19 files modified
.pre-commit-config.yaml (+19/-0) CONTRIBUTING.md (+14/-5) Makefile (+48/-7) contrib/fcb-stein-bionic.yaml (+1/-1) contrib/fcb-ussuri-bionic-ovs.yaml (+1/-1) contrib/fcb-ussuri-bionic.yaml (+1/-1) contrib/fcb-ussuri-focal-ovs.yaml (+1/-1) contrib/fcb-ussuri-focal.yaml (+1/-1) contrib/fcb-yoga-focal.yaml (+1/-1) contrib/includes/aggregator-kubernetes.yaml (+16/-0) contrib/includes/release/stein.yaml (+1/-1) contrib/includes/release/ussuri.yaml (+1/-1) contrib/includes/release/yoga.yaml (+1/-1) contrib/includes/series/focal.yaml (+1/-1) contrib/kubernetes.yaml (+1/-17) setup.py (+1/-1) tests/requirements.txt (+2/-0) tests/test_jujulint.py (+5/-0) tox.ini (+28/-18) |
||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Kalcok (community) | Approve | ||
Eric Chen | Approve | ||
Review via email: mp+426219@code.launchpad.net |
Commit message
applied pattern of bootstack charms for make and tox commands.
- added pre-commit support.
- solved lint issues.
- removed debug flag to build snap. If the build fails, it should
stop the CI and not open the shell from the snap.
- added an aggregator-
- changed tox and make commands to match scripts on the bootstack CI.
Closes-Bug: #1978739
Partial-Bug: #1978841
To post a comment you must log in.
This merge proposal is being monitored by mergebot. Change the status to Approved to merge.