Code review comment for ~gabriel-samfira/simplestreams:use-region-name

Revision history for this message
Gabriel Samfira (gabriel-samfira) wrote :

Hi Erlon,

The code to add, parse and store region is already there:

https://git.launchpad.net/simplestreams/tree/bin/sstream-mirror-glance#n65

I tested it by deploying it and having it work as intended. In a multi-region shared keystone environment, with this patch, simplestreams uploaded the glance image to the correct region. Without it, it always attempted to connect to the glance endpoint from a different region.

Same for swift.

« Back to merge proposal