Code review comment for lp:~gabriel-samfira/charms/trusty/neutron-api/next

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Thank you for your work in this proposal. While I'll defer to a colleague for a review of the proposed content changes, I can help advise from the test perspective.

The amulet test will need to be updated in your branch to also expect the hyperv mechanism_driver in the ml2 config file for Trusty-Kilo and later.

Here is the specific failure point:
test_301_ml2_config DEBUG: Checking ml2 config file data...
...
section [ml2] mechanism_drivers:openvswitch,l2population,hyperv != expected mechanism_drivers:openvswitch,l2population
...
juju-test.conductor.017-basic-trusty-kilo DEBUG : Got exit code: 1

Here is an example from another charm test, solving a similar need:
http://bazaar.launchpad.net/~1chb1n/charms/trusty/keystone/amulet-svc-check-race-fix/view/head:/tests/basic_deployment.py#L402

review: Needs Fixing

« Back to merge proposal