Code review comment for lp:~gabor-karsay/awn-extras/comics

Revision history for this message
Gabor Karsay (gabor-karsay) wrote :

Fixed the change in gocomics' feeds and a change in glade-3.

Referring to the preinstalled comics: I can't see a way to retrieve a list of comics automatically from gocomics.com (neither from comics.com, which requires registration and has very strict terms of use). So we'd probably have to create this list and maintain it ourselves - and that would be the same as preinstalling some of them (the user can still decide whether these comics are shown or not).

Actually users can add comics using the assistant. They only have to know the URL of the feed and then select the image showing the comic. It's as easy as copy & paste a backtrace to a bug report. That means: it might be way too difficult for some users ;-) That's why we have some preinstalled comics.

I agree that some of the preinstalled comics are not suited for a wide audience. I'm inclined to remove buttersafe and explosm because they are sort of weird. gocomics.com can sort its comics by popularity. I added Calvin & Hobbes because it's the most popular comic, Garfield is #3. wulffmorgenthaler was a user request, it is regularly updated and I like it (but some strips may be not suitable for children, lets say aged 12 or less).

review: Needs Resubmitting

« Back to merge proposal