Merge lp:~gabipetrovay/zorba/moduleDocumentation into lp:zorba

[Gabriel Petrovay]

Disabled moduleDocumentation test due to 871335.

Disabled moduleDocumentation test due to 871335.

I guess this will not succeed because now the image module will not be changed. :(

[Gabriel Petrovay (gabipetrovay)]

review: Approve

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/moduleDocumentation-2011-10-09T15-41-28.913Z/log.html

[Zorba Build Bot (zorba-buildbot)]

The attempt to merge lp:~gabipetrovay/zorba/moduleDocumentation into lp:zorba failed. Below is the output from the failed tests.

CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:272 (message):
  Validation queue job moduleDocumentation-2011-10-09T15-41-28.913Z is
  finished. The final status was:

  No tests were run - build or configure step must have failed.

  Not commiting changes.

Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/moduleDocumentation-2011-10-09T15-51-15.827Z/log.html

[Zorba Build Bot (zorba-buildbot)]

The attempt to merge lp:~gabipetrovay/zorba/moduleDocumentation into lp:zorba failed. Below is the output from the failed tests.

CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:272 (message):
  Validation queue job moduleDocumentation-2011-10-09T15-51-15.827Z is
  finished. The final status was:

  1 tests did not succeed - changes not commited.

Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

[lp:~gabipetrovay/zorba/moduleDocumentation]

10503. By Gabriel Petrovay on 2011-10-09

Disabled the moduleDocumentation test because of already commited modules with broken documentaiton which stop submitting other patches. It is the case of the image modules.

10504. By Gabriel Petrovay on 2011-10-09

The previous commit brakes the Windows build because a wrong EXPECTED_FAILURE has been commented out.

Unmerged revisions

=== modified file 'test/rbkt/Queries/CMakeLists.txt'
--- test/rbkt/Queries/CMakeLists.txt	2011-10-09 01:05:46 +0000
+++ test/rbkt/Queries/CMakeLists.txt	2011-10-09 16:13:29 +0000
@@ -32,12 +32,21 @@
 # appropriate. IF YOU THINK YOU WANT TO DO THIS, YOU ARE PROBABLY
 # WRONG OR THERE IS A SERIOUS PROBLEM WITH THE BUILD SYSTEM.
 # PLEASE DO NOT USE THIS MECHANISM IF AT ALL POSSIBLE.
-# IF STILL NEEDED, GIVE THE CORRESPONDING BUG PRIORITY 9 BECAUSE
-# THIS HAS TO BE ADDRESSED ASAP.
+# IF STILL NEEDED, GIVE THE CORRESPONDING BUG IMPORTANCE "CRITICAL"
+# BECAUSE THIS HAS TO BE ADDRESSED ASAP.
 LIST(REMOVE_ITEM TESTFILES
 
-# Crashes on Windows: 3284881, 3071699 (fix 3284881 before 3071699)
+  # crashes on Windows: 866978, 866742 (fix 866978 before 866742)
   zorba/HigherOrder/hof-101.xq
+
+  # fails because of the image external module's broken documentation
+  # If you try to submit something else to the external module, it will
+  # fail because of this test.
+  # If you try and mark it as expected failure here, the "expected failure"
+  # will fail because the image module will not be tested and therefore the
+  # module documentation test will succeed.
+  # Created bug 871335 for this.
+  zorba/xqdoc/moduleDocumentation.xq
 )
 
 # collect all chained test queries (suffix .cxq) in all subdirectories
@@ -251,10 +260,13 @@
 
   EXPECTED_FAILURE(test/rbkt/zorba/versioning/link1 871061)
   EXPECTED_FAILURE(test/rbkt/zorba/xqdoc/moduleDocumentation 871062)
-  
-  EXPECTED_FAILURE(test/rbkt/zorba/file/createWriteReadDeleteSeries 3276394)
+
+  # this is still an expected failure but has been commented out since the
+  # test is now completely disabled because of bug 871335
+  #EXPECTED_FAILURE(test/rbkt/zorba/file/createWriteReadDeleteSeries 866969)
 ENDIF(WIN32)
 
+
 EXPECTED_FAILURE(test/rbkt/zorba/modules/schema 3131554)
 
 EXPECTED_FAILURE(test/rbkt/zorba/xqddf/ic-uniqueKey-err2 2935047)