Code review comment for lp:~fwierzbicki/txaws/break-out-parse-instance

Revision history for this message
Jamu Kakar (jkakar) wrote :

[1]

+ def _parse_instance(self, instance_data, reservation):

Please add a docstring to this method with @param and @return
components.

Also, it sounds like you'll be calling this method from Landscape
code... do we want it to be private, in that case? It could change
under you if someone else refactors it without knowing its used in
Landscape.

review: Needs Information

« Back to merge proposal