Code review comment for lp:~fwereade/pyjuju/webdav-unicode-paths

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

> I suspect that any code I write to do this properly is unlikely to be
> executed outside a test context

You'd be surprised with what people do. ;-)


9 + name = _safe_string(name)
10 + path = "%s/%s" % (self._bucket, urllib.quote(name))
11 signed =, digestmod=sha)
12 signed.update("GET\n\n\n%s\n/%s" % (expires, path))

I'm fine with just going ahead with this and fixing it later if necessary because
we've already spent too much time on this detail, but I won't be surprised if we
find issues with this in practice. The quoting algorithm used by urllib.quote
and the one expected by Amazon must match _precisely_ for this to work, and must
continue to be so in the future.

review: Approve

« Back to merge proposal