Code review comment for lp:~fwereade/pyjuju/shadow-trunk-1204

Reviewers: mp+100195_code.launchpad.net,

Message:
Please take a look.

Description:
Constraints feature

End result of many branches merged into
lp:~fwereade/juju/shadow-trunk-1204
over the last couple of weeks. Includes provider-specific constraint
registration (not global), provision for legacy deployments, and
environment
constraints.

https://code.launchpad.net/~fwereade/juju/shadow-trunk-1204/+merge/100195

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/5971047/

Affected files:
   A [revision details]
   A docs/source/internals/constraints-notes.rst
   M juju/agents/provision.py
   M juju/agents/tests/common.py
   M juju/agents/tests/test_machine.py
   M juju/agents/tests/test_provision.py
   M juju/control/__init__.py
   M juju/control/add_unit.py
   M juju/control/bootstrap.py
   A juju/control/constraints_get.py
   M juju/control/constraints_set.py
   M juju/control/deploy.py
   M juju/control/initialize.py
   A juju/control/legacy.py
   M juju/control/terminate_machine.py
   M juju/control/tests/test_add_relation.py
   M juju/control/tests/test_add_unit.py
   M juju/control/tests/test_bootstrap.py
   M juju/control/tests/test_config_get.py
   M juju/control/tests/test_config_set.py
   A juju/control/tests/test_constraints_get.py
   M juju/control/tests/test_constraints_set.py
   M juju/control/tests/test_control.py
   M juju/control/tests/test_debug_hooks.py
   M juju/control/tests/test_debug_log.py
   M juju/control/tests/test_deploy.py
   M juju/control/tests/test_destroy_service.py
   M juju/control/tests/test_initialize.py
   M juju/control/tests/test_remove_unit.py
   M juju/control/tests/test_resolved.py
   M juju/control/tests/test_scp.py
   M juju/control/tests/test_ssh.py
   M juju/control/tests/test_status.py
   M juju/control/tests/test_terminate_machine.py
   M juju/control/tests/test_upgrade_charm.py
   M juju/control/tests/test_utils.py
   M juju/control/utils.py
   M juju/environment/config.py
   M juju/environment/tests/test_config.py
   M juju/hooks/tests/test_invoker.py
   M juju/machine/constraints.py
   M juju/machine/tests/test_constraints.py
   M juju/machine/unit.py
   M juju/providers/common/base.py
   M juju/providers/common/bootstrap.py
   M juju/providers/common/cloudinit.py
   M juju/providers/common/launch.py
   M juju/providers/common/tests/data/cloud_init_bootstrap
   M juju/providers/common/tests/data/cloud_init_bootstrap_zookeepers
   M juju/providers/common/tests/data/cloud_init_distro
   M juju/providers/common/tests/data/cloud_init_ppa
   M juju/providers/common/tests/test_base.py
   M juju/providers/common/tests/test_bootstrap.py
   M juju/providers/common/tests/test_cloudinit.py
   M juju/providers/common/tests/test_launch.py
   M juju/providers/dummy.py
   M juju/providers/ec2/__init__.py
   M juju/providers/ec2/launch.py
   M juju/providers/ec2/tests/common.py
   M juju/providers/ec2/tests/data/bootstrap_cloud_init
   M juju/providers/ec2/tests/test_bootstrap.py
   M juju/providers/ec2/tests/test_launch.py
   M juju/providers/ec2/tests/test_provider.py
   M juju/providers/ec2/tests/test_utils.py
   M juju/providers/ec2/utils.py
   M juju/providers/local/__init__.py
   M juju/providers/local/tests/test_provider.py
   M juju/providers/maas/launch.py
   M juju/providers/maas/maas.py
   M juju/providers/maas/provider.py
   M juju/providers/maas/tests/test_launch.py
   M juju/providers/maas/tests/test_maas.py
   M juju/providers/maas/tests/test_provider.py
   M juju/providers/maas/tests/testing.py
   M juju/providers/orchestra/__init__.py
   M juju/providers/orchestra/cobbler.py
   M juju/providers/orchestra/launch.py
   M juju/providers/orchestra/tests/common.py
   M juju/providers/orchestra/tests/data/bootstrap_user_data
   M juju/providers/orchestra/tests/test_bootstrap.py
   M juju/providers/orchestra/tests/test_cobbler.py
   M juju/providers/orchestra/tests/test_launch.py
   M juju/providers/orchestra/tests/test_provider.py
   M juju/providers/tests/test_dummy.py
   M juju/state/environment.py
   M juju/state/initialize.py
   M juju/state/machine.py
   M juju/state/service.py
   M juju/state/tests/common.py
   M juju/state/tests/test_environment.py
   M juju/state/tests/test_firewall.py
   M juju/state/tests/test_initialize.py
   M juju/state/tests/test_machine.py
   M juju/state/tests/test_placement.py
   M juju/state/tests/test_relation.py
   M juju/state/tests/test_service.py
   M juju/unit/tests/test_charm.py
   M juju/unit/tests/test_deploy.py