Code review comment for lp:~fwereade/pyjuju/orchestra-series-constraints

Reviewers: mp+101670_code.launchpad.net,

Message:
Please take a look.

Description:
orchestra provider now respects ubuntu-series constraint

This is done by setting a new system profile before powering on the
machine;
the only wrinkle is that the only way to detect the machine's actual
arch is
by inferring it from the original system profile.

This assumes that the Cobbler system profiles created as part of the
ubuntu-orchestra-server install actually exist; anecdotal evidence
suggests
that people really don't mess with the distros and profiles available
(they
just set up their systems and go) and so I consider the impact of this
drawback to be extremely limited. Furthermore, we're not actually going
to
get any real arch data out of cobbler *anyway* -- to make this work at
all,
we depend on extracting it from some sort of profile naming convention
--
and so we may as well depend on the convention that already exists.

https://code.launchpad.net/~fwereade/juju/orchestra-series-constraints/+merge/101670

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/6012045/

Affected files:
   A [revision details]
   M juju/providers/orchestra/cobbler.py
   M juju/providers/orchestra/launch.py
   M juju/providers/orchestra/tests/common.py
   M juju/providers/orchestra/tests/data/bootstrap_user_data
   M juju/providers/orchestra/tests/test_bootstrap.py
   M juju/providers/orchestra/tests/test_cobbler.py
   M juju/providers/orchestra/tests/test_launch.py