Code review comment for lp:~fwereade/pyjuju/cobbler-connect-production
Revision history for this message
| William Reade (fwereade) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> [1] Just a naming thing, but i'd change CobblerConnect to CobblerConnection
Hm, it's not really a *connection* as such, but I agree it's not a very helpful name; I think CobblerClient fits better for now.
> [2] random thoughts.
>
> For launching machines is there anyway to distinguish size/hardware
> capabilities? I'm just thinking that in the future, we'll want to have some
> abstracted notion of machine size so we can utilize them for deploying
> services that need additional hardware capabilities available to a machine
> provider.
Not yet; agree we'll need it at some stage.
> [3] Some pep8/syntax items that came up captured in diff to fix.
> https:/
Thanks :).
> [4] I'm curious what the ensemble late command stuff is.. it might be nice to
> have some documentation of the orchestration integration when all of this said
> and done.
It's basically just writing the user-data/meta-data files for cloud-init. I agree that we'll want documentation for the Orchestra provider, but there are still a fair number of unanswered questions, so I'm not sure it's quite the right time yet.