Code review comment for lp:~fwereade/pyjuju/cobbler-connect-production

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

I can't speak at all to what this means in terms of cobbler/orchestra interaction but code style/syntax looks good.

[0] This bit appears unused and extraneous.

ensemble/lib/testing.py

74 + client_got = False
75 +

[1] Just a naming thing, but i'd change CobblerConnect to CobblerConnection

[2] random thoughts.

For launching machines is there anyway to distinguish size/hardware capabilities? I'm just thinking that in the future, we'll want to have some abstracted notion of machine size so we can utilize them for deploying services that need additional hardware capabilities available to a machine provider.

[3] Some pep8/syntax items that came up captured in diff to fix.
https://pastebin.canonical.com/50619/

[4] I'm curious what the ensemble late command stuff is.. it might be nice to have some documentation of the orchestration integration when all of this said and done.

« Back to merge proposal