Code review comment for lp:~fwereade/juju-core/uniter-relation-states

Reviewers: mp+215003_code.launchpad.net,

Message:
Please take a look.

Description:
worker/uniter: startup with correct relation state

The uniter's runListener is not started until after relation state is
set
up; and relation state setup is fixed to use true relation state from
the
API server rather than the local best guess, which is inaccurate when
any
joined relation has never seen a remote unit.

This involves a new API, which the unit agent will wait for, in case it
connects to an API server which hasn't yet been upgraded.

https://code.launchpad.net/~fwereade/juju-core/uniter-relation-states/+merge/215003

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/85670046/

Affected files (+356, -67 lines):
   A [revision details]
   M state/api/uniter/unit.go
   M state/api/uniter/unit_test.go
   M state/api/uniter/uniter.go
   M state/apiserver/uniter/uniter.go
   M state/apiserver/uniter/uniter_test.go
   M state/unit.go
   M state/unit_test.go
   M testing/filetesting/filetesting_test.go
   M worker/uniter/modes.go
   M worker/uniter/relationer.go
   M worker/uniter/relationer_test.go
   M worker/uniter/uniter.go
   M worker/uniter/uniter_test.go